Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): module-federation-ssr-dev-server should use fork #13791

merged 2 commits into from Dec 13, 2022


Copy link

@Coly010 Coly010 commented Dec 13, 2022

Current Behavior

The remotes were not being served correctly, using the default port for each.

Expected Behavior

Each remote should be served on their dedicated port

@Coly010 Coly010 requested a review from jaysoo December 13, 2022 10:10
@Coly010 Coly010 self-assigned this Dec 13, 2022
Copy link

vercel bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 13, 2022 at 6:53PM (UTC)

Copy link

nx-cloud bot commented Dec 13, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 51666e3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Successfully ran 21 targets

Sent with 💌 from NxCloud.

@Coly010 Coly010 enabled auto-merge (squash) December 13, 2022 19:00
@Coly010 Coly010 merged commit 61af68b into nrwl:master Dec 13, 2022
13 checks passed
@Coly010 Coly010 deleted the react/ssr-mf-executor branch December 13, 2022 19:18
FrozenPandaz pushed a commit that referenced this pull request Dec 19, 2022
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants