Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): host should use module-federation-ssr-dev-server #13794

merged 1 commit into from Dec 13, 2022


Copy link

@Coly010 Coly010 commented Dec 13, 2022

Current Behavior

Host currently uses webpack ssr dev server for serving with SSR. This means it does not start up the remotes it depends on.

Expected Behavior

The host should the use module-federation-ssr-dev-server to serve the remotes and then the host

@Coly010 Coly010 requested a review from jaysoo December 13, 2022 10:59
@Coly010 Coly010 self-assigned this Dec 13, 2022
Copy link

vercel bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 13, 2022 at 11:00AM (UTC)

@jaysoo jaysoo merged commit 8ffa9fd into nrwl:master Dec 13, 2022
13 checks passed
@Coly010 Coly010 deleted the react/host-uses-mf-executor branch December 13, 2022 18:23
FrozenPandaz pushed a commit that referenced this pull request Dec 19, 2022
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants