Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ignore angular.json projects if @nrwl/angular is not insta… #13827

merged 1 commit into from Dec 14, 2022


Copy link


Current Behavior

Most workspaces use Nx and Angular together. However, workspaces which use Nx and Angular CLI entirely independently have a conflict in some package names.

Expected Behavior

Projects that use Nx and Angular entirely independently do not have @nrwl/angular installed and should not read projects from angular.json

Related Issue(s)

Fixes #

Copy link

vercel bot commented Dec 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev Ready (Inspect) Visit Preview Dec 14, 2022 at 7:25PM (UTC)

Copy link

nx-cloud bot commented Dec 14, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bda2a75. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
nx depcheck --no-dte
Successfully ran 18 targets

Sent with 💌 from NxCloud.

@@ -431,6 +432,15 @@ function assertValidWorkspaceConfiguration(

function isNrwlAngularInstalled() {
try {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some debate on whether require.resolve vs reading package.json and checking deps is better for this check.

This could potentially have a false positive if there was @nrwl/angular found in one of the dependency chains of another installed library, but that should be relatively rare. In any case, the behavior exhibited would be the currently existing behavior, so its a low impact.

@FrozenPandaz FrozenPandaz merged commit 92d33f9 into nrwl:master Dec 14, 2022
13 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants