Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): default bundler to vite when deprecated buildable option is used #13857



Copy link

@jaysoo jaysoo commented Dec 15, 2022

If user use the deprecated --buildable option, and chooses bundler: none at the prompt, then the library is not buildable.

We should warn them and pick a default. For now the default should be rollup for any existing workspaces passing --buildable. In Nx 16 we can change this to be vite.

Current Behavior

Generated library is not buildable even though --buildable is passed.

Expected Behavior

Generated library should be buildable.

Related Issue(s)

Fixes #

Copy link

vercel bot commented Dec 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 15, 2022 at 8:05PM (UTC)

@jaysoo jaysoo force-pushed the fix/react-buildable-lib-default-bundler branch from fb34025 to 592be8f Compare December 15, 2022 20:03
@jaysoo jaysoo force-pushed the fix/react-buildable-lib-default-bundler branch from 592be8f to 1a4163b Compare December 15, 2022 20:04
@FrozenPandaz FrozenPandaz merged commit 99983e9 into nrwl:master Dec 15, 2022
13 checks passed
FrozenPandaz pushed a commit that referenced this pull request Dec 19, 2022
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants