Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): handle not provided path when generating a component without the project option #13877



Copy link

Current Behavior

Generating a component from the workspace root without providing the project and path options throws an error.

Expected Behavior

Generating a component from the workspace root without providing the project and path options should not throw and fallback to use the set defaultProject. Only if defaultProject is not set we throw a meaningful error to the user.

Related Issue(s)

Fixes #13874

@leosvelperez leosvelperez self-assigned this Dec 16, 2022
Copy link

vercel bot commented Dec 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 17, 2022 at 11:06AM (UTC)

@leosvelperez leosvelperez marked this pull request as draft December 16, 2022 15:50
@leosvelperez leosvelperez force-pushed the angular/component-generator-null-path branch from 54c5e28 to 7f62377 Compare December 17, 2022 11:05
@leosvelperez leosvelperez marked this pull request as ready for review December 17, 2022 11:06
Copy link

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@FrozenPandaz FrozenPandaz merged commit 4e54b1a into nrwl:master Dec 19, 2022
13 checks passed
FrozenPandaz pushed a commit that referenced this pull request Dec 19, 2022
…thout the project option (#13877)

(cherry picked from commit 4e54b1a)
@leosvelperez leosvelperez deleted the angular/component-generator-null-path branch December 20, 2022 11:54
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

Error while creating Angular component: The "path" argument must be of type string. Received undefined
3 participants