Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): missing remotes form mf config should not break mf server #13901



Copy link

@Coly010 Coly010 commented Dec 19, 2022

Current Behavior

When using dynamic module federation the remotes key could be missing from the module-federation.config.js. Currently, this will cause the module-federation-dev-server to error.

Expected Behavior

This scenario should not cause an error

@Coly010 Coly010 self-assigned this Dec 19, 2022
Copy link

vercel bot commented Dec 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 19, 2022 at 11:52AM (UTC)

Copy link

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@Coly010 Coly010 merged commit dc4a123 into nrwl:master Dec 20, 2022
13 checks passed
@Coly010 Coly010 deleted the angular/fix-mf-dev-server-remote-finding branch December 20, 2022 09:19
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants