Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix lock file pruning multiple versions of dependencies #13915



Copy link

Current Behavior

Multiple package versions are omitted from the pruned .lock file.

Expected Behavior

Multiple package versions should be included in the .lock file

Related Issue(s)

Fixes #

Copy link

vercel bot commented Dec 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev Ready (Inspect) Visit Preview Dec 22, 2022 at 10:30AM (UTC)

Copy link
Contributor Author

Hello @meeroslav,
I found another issue with the lockfile pruning in 15.4.0-beta.2, maybe you can take a look if those changes are appropriate.
Thank you!

Copy link

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

Copy link

Can you rebase to the latest master, please? That should fix the failing E2E test.

@skrtheboss skrtheboss force-pushed the fix/lock-file-pruning-multiple-versions branch from d8c8b9c to eaa70f3 Compare December 22, 2022 10:27
@meeroslav meeroslav merged commit c51c178 into nrwl:master Dec 22, 2022
13 checks passed
@skrtheboss skrtheboss deleted the fix/lock-file-pruning-multiple-versions branch December 22, 2022 10:59
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants