Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): change ignoreTestFiles to excludeSpecPattern for cy10+ #13942


Copy link

@barbados-clemens barbados-clemens commented Dec 20, 2022

Current Behavior

when using > Cypress 10 the option ignoreTestFiles was renamed to excludeSpecPattern

Expected Behavior

when using > Cypress 10 should use excludeSpecPattern instead of ignoreTestFiles

Related Issue(s)

the option has to be passed via the testingType level of config instead of the root level option since the excludeSpecPattern has move from the root level to the e2e/component level.

Fixes #13860

Copy link

vercel bot commented Dec 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev Ready (Inspect) Visit Preview Dec 21, 2022 at 3:38PM (UTC)

@barbados-clemens barbados-clemens merged commit e91179e into nrwl:master Dec 27, 2022
13 checks passed
@barbados-clemens barbados-clemens deleted the fix/cy-options-excludeSpecPattern branch December 27, 2022 17:28
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
scope: testing tools Issues related to Cypress / Jest support in Nx
None yet

Successfully merging this pull request may close these issues.

cypress 10.0 renamed ignoreTestFiles to excludeSpecPattern but @nrwl/cypress wasn't updated
2 participants