Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): consult root package.json when resolving peer deps on package generation #13949



Copy link

@meeroslav meeroslav commented Dec 21, 2022

Currently, we ignore all optional peer dependencies when generating package.json.
Unfortunately, packages such as nest (requires optional @nestjs\platform-express) would fail with missing dependencies.

Current Behavior

Optional peer dependencies of direct dependencies are not added to the generated package.json

Expected Behavior

Optional peer dependencies of direct dependencies should be added to the generated package.json if they are listed as dependencies in the root package.json.

Related Issue(s)

Fixes #13625

@meeroslav meeroslav self-assigned this Dec 21, 2022
Copy link

vercel bot commented Dec 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev Ready (Inspect) Visit Preview Dec 21, 2022 at 1:28PM (UTC)

@meeroslav meeroslav added the scope: core core nx functionality label Dec 21, 2022
@FrozenPandaz FrozenPandaz merged commit f3465a9 into nrwl:master Dec 21, 2022
13 checks passed
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Dec 21, 2022
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
@meeroslav meeroslav deleted the fix-generate-package-json-peer-deps branch April 13, 2023 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
scope: core core nx functionality
None yet

Successfully merging this pull request may close these issues.

@nrwl/nest - Generated package.json does not include @nestjs/platform-express starting with nx 15.2.2
3 participants