fix(core): consult root package.json when resolving peer deps on package generation #13949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Currently, we ignore all optional peer dependencies when generating package.json.
Unfortunately, packages such as
nest
(requires optional@nestjs\platform-express
) would fail with missing dependencies.Current Behavior
Optional peer dependencies of direct dependencies are not added to the generated package.json
Expected Behavior
Optional peer dependencies of direct dependencies should be added to the generated package.json if they are listed as dependencies in the root package.json.
Related Issue(s)
Fixes #13625