Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): do not generate component in lib by default #19755

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

mandarini
Copy link
Member

Just like Angular, Vue libraries might not need a vue component in them. They could be a directive, service, etc.

So just like Angular, we should not generate a component

@mandarini mandarini requested a review from a team as a code owner October 20, 2023 13:14
@mandarini mandarini requested a review from jaysoo October 20, 2023 13:14
@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2023 1:15pm

@mandarini mandarini self-assigned this Oct 20, 2023
@mandarini mandarini merged commit 54865ae into nrwl:master Oct 20, 2023
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Oct 20, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants