From 8445a38e1a5bed8af7064040f09da0f38a65ea48 Mon Sep 17 00:00:00 2001 From: Jack Hsu Date: Wed, 21 Feb 2024 11:15:36 -0500 Subject: [PATCH] fix(webpack): surface original error when remotes fail to start --- .../module-federation-dev-server.impl.ts | 7 +++++-- .../module-federation-dev-server.impl.ts | 7 +++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/packages/angular/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts b/packages/angular/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts index fddd2e231a001..3e2e6fc466cb5 100644 --- a/packages/angular/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts +++ b/packages/angular/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts @@ -192,9 +192,12 @@ export async function* moduleFederationDevServerExecutor( `NX All remotes started, server ready at http://localhost:${options.port}` ); next({ success: true, baseUrl: `http://localhost:${options.port}` }); - } catch { + } catch (err) { throw new Error( - `Timed out waiting for remote to start. Check above for any errors.` + `Failed to start remotes. Check above for any errors.`, + { + cause: err, + } ); } finally { done(); diff --git a/packages/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts b/packages/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts index 5d17e5084a5db..d5ff20087e25f 100644 --- a/packages/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts +++ b/packages/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts @@ -337,9 +337,12 @@ export default async function* moduleFederationDevServer( logger.info(`NX All remotes started, server ready at ${baseUrl}`); next({ success: true, baseUrl: baseUrl }); - } catch { + } catch (err) { throw new Error( - `Timed out waiting for remote to start. Check above for any errors.` + `Failed to start remotes. Check above for any errors.`, + { + cause: err, + } ); } finally { done();