Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graph): reload graph app only when hash changes in watch mode #23434

Merged
merged 1 commit into from
May 16, 2024

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented May 16, 2024

Current Behavior

In watch mode (which is the default now), the graph app reloads every 5 seconds, even if nothing changed. This causes tooltips to close & the graph location to reset.

Expected Behavior

We don't want to reset the app every 5 seconds if nothing changed.

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 1:26pm

@MaxKless MaxKless enabled auto-merge (squash) May 16, 2024 13:53
@MaxKless MaxKless merged commit c7f60fc into master May 16, 2024
6 checks passed
@MaxKless MaxKless deleted the reload-graph-hash-change branch May 16, 2024 14:23
FrozenPandaz pushed a commit that referenced this pull request May 21, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants