add unviersal arg to easily unhighlight all symbols #1

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
2 participants
@lewang

lewang commented Feb 25, 2012

...ghlights

@nschum

This comment has been minimized.

Show comment Hide comment
@nschum

nschum Jan 4, 2013

Owner

Thank you. Sorry for the late response. I'm currently not using Emacs much.

I'm not a big fan of using the prefix argument to remove all symbols. It seems too asymmetric. There is a function for that after all. I also wouldn't want to replace y-or-n-p' withread-char, sincey-or-n-p' has a lot of subtle features that people might expect. If you find a way to use `y-or-n-p', I'd support adding it to interactive calls of highlight-symbol-remove-all.

What I really like is the colored list of highlighted symbols. So I've included that. Thanks!

Owner

nschum commented Jan 4, 2013

Thank you. Sorry for the late response. I'm currently not using Emacs much.

I'm not a big fan of using the prefix argument to remove all symbols. It seems too asymmetric. There is a function for that after all. I also wouldn't want to replace y-or-n-p' withread-char, sincey-or-n-p' has a lot of subtle features that people might expect. If you find a way to use `y-or-n-p', I'd support adding it to interactive calls of highlight-symbol-remove-all.

What I really like is the colored list of highlighted symbols. So I've included that. Thanks!

@nschum nschum closed this Jan 4, 2013

@lewang

This comment has been minimized.

Show comment Hide comment
@lewang

lewang Jan 7, 2013

C-u prefix is used to indicate a more forceful version of a command. It applies well in this case.

I should have opened other pull-requests, but I've also included changes here that treats a selected region as a highlight target.

lewang commented Jan 7, 2013

C-u prefix is used to indicate a more forceful version of a command. It applies well in this case.

I should have opened other pull-requests, but I've also included changes here that treats a selected region as a highlight target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment