Skip to content

Patrick Chamelo
nscoding

nscoding commented on pull request facebook/ios-snapshot-test-case#141
@nscoding

Any update on this one?

@nscoding

Thanks for opening this issue, I would welcome a PR that describes how to solve cases like that in the ReadMe section.

nscoding commented on pull request facebook/ios-snapshot-test-case#143
@nscoding

Thanks for this there are some build errors, can you investigate?

@nscoding
@nscoding
add device agnostic tests & add helpful assertion for device agnostic tests
1 commit with 350 additions and 13 deletions
nscoding commented on pull request facebook/ios-snapshot-test-case#137
@nscoding

I guess this file was introduced for the device size right?

nscoding commented on pull request facebook/ios-snapshot-test-case#137
@nscoding

Do we need this?

nscoding commented on pull request facebook/ios-snapshot-test-case#141
@nscoding

Hey thanks for the PR, I introduced this with #127 #129 as a workaround because the project wouldn't build but not sure what's the right way. So w…

nscoding commented on pull request facebook/ios-snapshot-test-case#137
@nscoding

testSuccessfulComparisonOfDeviceAgnosticReferenceImages tests are failing, it's looking for 320x568 (iPhone 5 right? but we didn't provide this one)

nscoding commented on pull request facebook/ios-snapshot-test-case#137
@nscoding

Thank you for working on this, it looks great, I left a couple of comments (nit picks really).

nscoding commented on pull request facebook/ios-snapshot-test-case#140
@nscoding

got it, thanks!

@nscoding
@nscoding
Propagate correct file name and line number from Swift
1 commit with 2 additions and 2 deletions
nscoding commented on pull request facebook/ios-snapshot-test-case#137
@nscoding

can we also run this test (and record the image) for an iPhone 6?

nscoding commented on pull request facebook/ios-snapshot-test-case#137
@nscoding

recdeiver's typo

nscoding commented on pull request facebook/ios-snapshot-test-case#137
@nscoding

new line before {

nscoding commented on pull request facebook/ios-snapshot-test-case#137
@nscoding

oh I didn't see the updated commits

nscoding commented on pull request facebook/ios-snapshot-test-case#137
@nscoding

@bgerstle thoughts on my latest comment?

nscoding commented on pull request facebook/ios-snapshot-test-case#139
@nscoding

:+1:

@nscoding
@nscoding
Project tweaks
2 commits with 5 additions and 1 deletion
@nscoding

I don't have enough knowledge for this, @jspahrsummers any thoughts?

@nscoding
@nscoding
If a view is a UIWindow, then don't re-wrap it in a UIWindow before call to drawViewHierarchy
1 commit with 2 additions and 1 deletion
nscoding commented on pull request facebook/ios-snapshot-test-case#138
@nscoding

:+1: nice catch. Can you add a comment here to explain why we do this? Please also squash the commits once you update the code and I'll merge it in.

nscoding commented on pull request facebook/ios-snapshot-test-case#137
@nscoding

Sorry, I had to look at it a bit to figure out what is going on and there are a couple of issues: The build script that I added on travis is build…

nscoding commented on pull request facebook/ios-snapshot-test-case#137
@nscoding

oh, I was look at the project itself, you are right, this is configured correctly but yet [UIApplication sharedApplication] is still nil

nscoding commented on pull request facebook/ios-snapshot-test-case#137
@nscoding

Either we fix the project to have a host application (I am leaning toward this) or we don't rely on [UIApplication sharedApplication] but I don't s…

nscoding commented on pull request facebook/ios-snapshot-test-case#137
@nscoding

hmm I just cloned your PR, [UIApplication sharedApplication] is nil at this point. I believe mainly because of the project doesn't have a host appl…

Something went wrong with that request. Please try again.