Patrick Chamelo nscoding

@nscoding

@pietbrauer so we need #90 for this?

@nscoding
@nscoding
Revert "Remove destination requirement"
1 commit with 3 additions and 2 deletions
@nscoding
Revert "Remove destination requirement"
1 commit with 3 additions and 2 deletions
nscoding commented on pull request facebook/ios-snapshot-test-case#90
@nscoding

@pietbrauer this broke CI any ideas?

@nscoding

@pietbrauer Yes we should, is there any "how to" guide somewhere?

@nscoding
@nscoding
Remove destination requirement
3 commits with 2 additions and 3 deletions
nscoding commented on pull request facebook/ios-snapshot-test-case#90
@nscoding

@pietbrauer your are right, they look very well split. I will merge when I get to the office.

nscoding commented on pull request facebook/ios-snapshot-test-case#90
@nscoding

@pietbrauer so good! Do you want to squash the commit into one?

@nscoding
@nscoding
Bump version to 2.0.2
1 commit with 10 additions and 6 deletions
@nscoding
Bump version to 2.0.2
1 commit with 10 additions and 6 deletions
@nscoding
Problem with retina compare (2.0.x)
@nscoding

Thank you very much for opening this issue and helping out.

nscoding deleted branch nscoding/retina at facebook/ios-snapshot-test-case
@nscoding
@nscoding
Fix for retina comparisons
1 commit with 11 additions and 8 deletions
@nscoding
  • @nscoding 0243a1b
    Fix for retina comparisons
@nscoding

@x2on Do you want to patch #96 and give it a try? I am confident that this was the issue but just to make sure. Thank you for your time.

@nscoding
Fix for retina comparisons
1 commit with 9 additions and 6 deletions
@nscoding

I see, I think the problem is here, we should be using CGImageGetWidth() and CGImageGetHeight(). I will open a PR shortly.

@nscoding

I will check it today, it was removed because it was breaking the approximation comparison I believe. cc @nap-sam-dean