Permalink
Commits on Sep 27, 2017
  1. leverage gnulib on Android

    nshalman committed Sep 27, 2017
Commits on Aug 6, 2017
  1. gnulib

    nshalman committed Aug 6, 2017
  2. need AC 2.59 or greater

    nshalman committed Aug 6, 2017
Commits on Apr 6, 2017
  1. ID:472 - Fix The Most recent Addition/Erase date

    srinivasa_mareedu authored and zstyblik committed Jan 23, 2017
    Fix the Most recent Addition/Erase date are not matched between in-band and
    out-band.
    
    ipmitool SDR code doesn't have to check for valid date to print
    based on 'Delete SDR command supported' and 'Partial Add SDR command
    supported', if 0xffffffff is taken. Also 'Timestamp' data type needs to change
    to time_t(long) because same data type is using for gmtime(time_t) API, it has
    different behaviour for Linux and Windows C.
Commits on Apr 4, 2017
  1. ID:480 - Call EVP_CIPHER_CTX_free() instead of EVP_CIPHER_CTX_cleanup()

    Holger Liebig authored and zstyblik committed Apr 4, 2017
    Call EVP_CIPHER_CTX_free() instead of EVP_CIPHER_CTX_cleanup() to fix memory
    leak.
Commits on Mar 26, 2017
  1. ID:480 - ipmitool coredumps in EVP_CIPHER_CTX_init

    zstyblik committed Mar 12, 2017
    IPMI tool coredumps due to changes introduced in ID:461. This shouldn't be
    surprise as a NULL pointer is passed to init. Commit addresses this issue by
    calling EVP_CIPHER_CTX_new() instead of EVP_CIPHER_CTX_init(), which is
    deprecated, and by checking return value of call to former function.
Commits on Mar 19, 2017
  1. Make git revision more descriptive

    AlexanderAmelkin authored and zstyblik committed Feb 7, 2017
    The previously introduced mechanism of generating
    a git revision was only using the abbreviated hash.
    That approach doesn't give a clue whether version
    1.8.18.2c99bf6 is newer or older than 1.8.18.7f8d374.
    
    The project uses tags, so `git describe` can be
    employed to produce an incremental revision number
    since the last tag. Version 1.8.18.13 is much more
    understandable and comparable. Howerver that doesn't
    answer the question "what codebase was used". To
    address that, the abbreviated hash should also be
    preserved. Hence, this commit introduces a new
    versioning scheme like `1.8.18.13.gee01aa5`.
    
    For git snapshots when git program is absent the
    version will be like `1.8.18.0.gsnapshot`.
    
    For cases when .git directory is missing (Release
    compilation?) the suffix part will be omitted
    completely yielding a version like `1.8.18`.
    
    The suffix generation has been moved to the added
    csv-revision script. The script is absolutely
    POSIX-ly correct and doesn't require XSI or any
    other POSIX extensions.
Commits on Feb 8, 2017
  1. ID:477 - fru: Fix decoding of non-text data in get_fru_area_str()

    AlexanderAmelkin committed Feb 2, 2017
    The get_fru_area_str() function is used to decode FRU area
    fields into text. Areas may be encoded as text, binary,
    BCDplus or 6-bit ASCII. Decoding of 6-bit ASCII and BCDplus
    was broken. There was an error in the formulas used to
    calculate the resulting string length, plus the decoding
    formulas for BCDplus was wrong.
    
    For BCDplus the resulting length was considered equal
    the encoded data length, while in fact it's twice as big.
    Only one character instead of two was being extracted from
    a single input byte while two nibbles must have been taken
    into account.
    
    For 6-bit ASCII rounding of 3 to 4 bytes conversion was done
    improperly adding 2 to the original length instead of the
    result of multiplication.
  2. ID:479 - ekanalyzer: fix processing of custom mfg. fields

    AlexanderAmelkin committed Jan 24, 2017
    Ekanalyzer was not reading the type/length byte for the 2nd and
    subsequent custom fields. Also the message it displayed when
    lacked data for custom fields was very relaxing and incorrect.
Commits on Feb 2, 2017
  1. ID:478 - ekanalyzer: Fixed decoding of FRU fields

    AlexanderAmelkin committed Jan 23, 2017
    Got rid of the field decoding code that was only capable of
    processing ASCII and binary fields, and switched to using
    get_fru_area_str() that can also decode BCDplus and 6-bit ASCII
    and maybe will eventually be enabled to decode Unicode text
    as well.
    
    This is the first step to completely get rid of the completely
    awfully written FRU data decoding functionality of ekanalyzer
    that essentially duplicates that of ipmi_fru.c module.
  2. Add git hash and dirty mark to ipmitool version

    AlexanderAmelkin committed Aug 10, 2015
    Replace the static 'csv' suffix with a short hash
    and a 'dirty' mark (when the tree is modified).
    
    When git is not available, '.git_snapshot' suffix
    will be used.
Commits on Jan 30, 2017
  1. Add bootstrap support for Mac

    skleymenov authored and AlexanderAmelkin committed Mar 19, 2015
Commits on Jan 21, 2017
  1. ID:474 - Compile fix on nonlinux systems

    Leonid Nevecherya authored and zstyblik committed Jan 17, 2017
    This patch fixes compilation on systems without a separate <malloc.h>.
Commits on Jan 15, 2017
  1. ID:461 - Make compiler happier about changes related to OpenSSL 1.1

    zstyblik committed Jan 15, 2017
    Complaint was that ctx isn't initialized.
Commits on Nov 30, 2016
  1. ID:461 - OpenSSL 1.1 compatibility - "error: storage size of 'ctx' is…

    urzds committed Nov 30, 2016
    …n't known"
    
    In OpenSSL 1.1 EVP_CIPHER_CTX became opaque, cf. `man 3ssl EVP_EncryptInit`
    
    Fixes: ID:461
Commits on Nov 2, 2016
  1. fix typo

    b-spruck committed Sep 6, 2016
Commits on Oct 8, 2016
  1. Release Version 1.8.18

    zstyblik committed Oct 8, 2016
    Update ChangeLog, configure.ac
Commits on Oct 6, 2016
  1. ID:465 - Supermicro memory ecc Modify the memory ecc error display of…

    kcl@supermicro.com.tw authored and zstyblik committed Oct 5, 2016
    … SEL for new supermicro boards.
Commits on Sep 24, 2016
  1. ID: 464 - ipmievd crash fix in log_event

    heronin authored and zstyblik committed Sep 16, 2016
    added missing format specifier for sensor number in lprintf
  2. ID:463 - Removal of Nokia Siemens Networks

    Mikko Piironen authored and zstyblik committed Sep 12, 2016
Commits on Sep 6, 2016
  1. fix typo

    b-spruck committed Sep 6, 2016
Commits on Sep 1, 2016
  1. replaced/removed defines which are already present in ipmi_picmg.h

    b-spruck committed Sep 1, 2016
    Signed-off-by: Bjoern Spruck <bspruck@uni-mainz.de>
  2. added microTCA major version

    b-spruck committed Sep 1, 2016
    Signed-off-by: Bjoern Spruck <bspruck@uni-mainz.de>
  3. fix typo

    b-spruck committed Sep 1, 2016
    Signed-off-by: Bjoern Spruck <bspruck@uni-mainz.de>
Commits on Aug 31, 2016
  1. ID:456 - Unable to disable the VLAN ID using ipmitool

    B BALAJI SINGH authored and zstyblik committed Aug 30, 2016
    Currently, when a LAN parameter set command is sent through ipmitool, the
    corresponding parameter data is requested and compared to the command to verify
    that the data was written correctly. Since we do send the VLAN ID in this return
    data, regardless of whether VLAN is disabled or not, this mismatch between
    requested and received parameters causes ipmitool to retry the command 10 times
    and return an error.
    
    ipmitool is sending "0x00 0x00" reading back data from BMC as "0x01 0x00" which
    is NOT matching & hence pops up the error /warning "LAN Parameter Data does not
    match! Write may have failed."
    After 10 retries when we check "ipmitool lan print" VLAN ID is disabled
    successfully.
Commits on Aug 28, 2016
  1. ID: 459 - Fix reading FRU on Artesyn (Emerson) shelf manager, MF105.

    Dmitry Rakhchev authored and zstyblik committed Aug 26, 2016
    Treat 0xC7 as an indication that requested data length in the
    FRU read shall be decreased.
Commits on Aug 21, 2016
  1. ID: 38 - Protocol violating SOL retries when talking to SIMSO-HTC

    zstyblik committed Aug 21, 2016
    c&p from the ticket:
    ~~~
    When I try to use CVS-ipmitool on Ubuntu 8.04 x86_64 to talk to a SuperMicros
    SIMSO-HTC (Rev. 2.5, IPMI 2.0) chip on a X7SBi-Board via SOL I often get doubled
    characters when typing fast, making the SOL interface basically unusable for
    anyone accustomed to using a keyboard for longer than a month ;)
    
    At first I thought this was an issue with SuperMicros implementation of the
    protocol and/or the flow control
    setup on the machine, but their own app works fine (but not the Linux CLI, which
    is maybe
    based on ipmitool?). But after reading the IPMI 2.0 SOL specs and watching the
    debug output for a bit, it seems that is really an issue with lanplus-SOL
    protocol implentation of ipmitool in general.
    
    Specifically, in lanplus.c:ipmi_lanplus_send_payload, when waiting for a SOL
    response the case that a non SOL packet is returned is not being
    checked. Also the "if (is_sol_packet(rsp) && rsp->data_len)" branch does
    terminate with a break, but instead goes for a send try, that seems
    counterintuitive, Both these things cause doubled characters for me.
    
    The attached patch seems to solve these issues in my case, but I don't claim to
    fully understand your protocol code and/or the protocol, so maybe it will cause
    problems elsewhere, especially under packet loss conditions.
    ~~~
  2. ID:457 - Display User ID enable/disable status

    zstyblik committed Aug 21, 2016
    Commit implements `Enable status` which shows/is in alignment with (22.27) Get
    User Access Command and displays User ID Enable/Disable status of given User ID
    at given channel.
  3. ID:454 - Add support for PICMG 3.1 R2.0 Link Types and Link Classes.

    Dan Gora authored and zstyblik committed Jul 28, 2016
    PICMG 3.1 R2.0 introduces new a new Link Class field in the FRU
    Link Descriptors which is the upper 4 bits of the Link Type field.
    This new Link Class field specifies SERDES lanes with 10.3125Gbd
    signalling rate.
    
    It also introduces the new Base-KX and Base-KX4 types which are the
    new IEEE replacements for the PICMG 3.0 Base-BX and Base-BX4 types.
    
    This patch decodes these new types and fields and will print out
    proper descriptions for each one based on PICMG 3.1 R2.0
  4. ID:375 - Add lan6 subcommand to handle IPv6 LAN parameters

    Dmitry Rakhchev authored and zstyblik committed Jul 4, 2016