Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

masked (marked bad) scan information does not properly carry through to subplots #1

Closed
nathanielsherry opened this issue Aug 24, 2010 · 0 comments
Assignees
Labels
Milestone

Comments

@nathanielsherry
Copy link
Collaborator

Because the dimensions of the data change, the index values used to store the bad scans are no longer accurate, and now mark the wrong scan as bad, or cause index out of bounds exceptions

for that reason, 'bad scan' data is intentionally discarded in Peakaboo 3 when creating a subplot view

This could be addressed by recalculating the index values, or by storing the 'bad scan' data as a boolean list in the DataSource object so that CopiedDataSource could do the index adjustments for it, as well

@nsherry4 nsherry4 self-assigned this Mar 9, 2018
@nsherry4 nsherry4 added the Bug label Mar 9, 2018
@nsherry4 nsherry4 added this to the Peakaboo 5 milestone Mar 9, 2018
nsherry4 added a commit that referenced this issue Mar 9, 2018
@nsherry4 nsherry4 closed this as completed Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants