mpi: Fix minor comment error #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged to upstream in r13838 (b21235f7) Thanks for the contribution! |
|
Thank you so much ! |
Vivek-anand-jain
pushed a commit
to Vivek-anand-jain/ns-3-dev-git
that referenced
this pull request
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codes in line number 126 and 127 adds leaf nodes on the right (according to the explanation in the diagram in the top of the source code) with system id 1, defined in previous lines. But the comments written in line number 125 does not describe what the following lines actually do, as it states that leaf nodes were being added to the left which apparently were already been added in previous lines above. This commenting error could cause problems for new users with minimum to no understanding of ns-3 usage. Suitable changes have been made i.e. left was changed to right.