Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve neofs-adm morph set-config error message #2556

Closed
evgeniiz321 opened this issue Sep 7, 2023 · 0 comments · Fixed by #2570
Closed

Improve neofs-adm morph set-config error message #2556

evgeniiz321 opened this issue Sep 7, 2023 · 0 comments · Fixed by #2570
Assignees
@AliceInHunterland
Labels
neofs-adm NeoFS Adm application issues
Milestone
v0.38.1

Comments

@evgeniiz321
Copy link

Is your feature request related to a problem? Please describe.

If we set a 'well-known' attribute using invalid type, we currently get the following error:

COMMAND: neofs-adm --config /home/runner/work/neofs-node/neofs-node/neofs-testcases/venv.local-pytest/../../neofs-dev-env/neofs-adm.yml morph set-config --rpc-endpoint 'http://morph-chain.neofs.devenv:30333' --alphabet-wallets '../neofs-dev-env/services/ir' HomomorphicHashingDisabled=0.2
RETCODE: 1

STDOUT:
Error: could not parse HomomorphicHashingDisabled's value '0.2' as bool: strconv.ParseBool: parsing "0.2": invalid syntax

Describe the solution you'd like

The error message shows some implementation details. It is better to display something like this:

Error: invalid type for HomomorphicHashingDisabled key, expected bool, got '0.2'

Describe alternatives you've considered

Additional context

Don't forget to add labels!

  • component label (neofs-adm, neofs-storage, ...)
  • issue type (enhancement, refactor, ...)
  • goodfirstissue, helpwanted if needed
  • does this issue belong to an epic?
  • priority (P0-P4) if already triaged
  • quarter label (202XQY) if possible
@evgeniiz321 evgeniiz321 added triage neofs-adm NeoFS Adm application issues labels Sep 7, 2023
@roman-khimov roman-khimov added this to the v0.39.0 milestone Sep 7, 2023
AliceInHunterland added a commit that referenced this issue Sep 12, 2023
@AliceInHunterland
neofs-adm: fix error messages for morph set-config
3e12bf8 
Errors messages previously contained some implementation details.

Closes #2556.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland AliceInHunterland mentioned this issue Sep 12, 2023
Merged
AliceInHunterland added a commit that referenced this issue Sep 12, 2023
@AliceInHunterland
neofs-adm: fix error messages for morph set-config
10bbe35 
Errors messages previously contained some implementation details.

Closes #2556.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@roman-khimov roman-khimov modified the milestones: v0.39.0, v0.38.0 Sep 12, 2023
AliceInHunterland added a commit that referenced this issue Sep 13, 2023
@AliceInHunterland
neofs-adm: fix error messages for morph set-config
cd07952 
Errors messages previously contained some implementation details.

Closes #2556.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@roman-khimov roman-khimov modified the milestones: v0.39.0, v0.38.1 Sep 13, 2023
AliceInHunterland added a commit that referenced this issue Sep 14, 2023
@AliceInHunterland
neofs-adm: fix error messages for morph set-config
fccb6a6 
Errors messages previously contained some implementation details.

Closes #2556.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Sep 14, 2023
@AliceInHunterland
neofs-adm: fix error messages for morph set-config
30ea5be 
Errors messages previously contained some implementation details.

Closes #2556.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Sep 14, 2023
@AliceInHunterland
neofs-adm: fix error messages for morph set-config
676d1e2 
Errors messages previously contained some implementation details.

Closes #2556.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Sep 14, 2023
@AliceInHunterland
neofs-adm: fix error messages for morph set-config
227deed 
Errors messages previously contained some implementation details.

Closes #2556.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
roman-khimov added a commit that referenced this issue Sep 14, 2023
@roman-khimov
neofs-adm: change morph set config error message (#2570)
d327e2e 
Closes #2556.
@roman-khimov roman-khimov mentioned this issue Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliceInHunterland AliceInHunterland

Labels
neofs-adm NeoFS Adm application issues
Projects
None yet
Milestone
v0.38.1
Development

Successfully merging a pull request may close this issue.

neofs-adm: change morph set config error message nspcc-dev/neofs-node
3 participants
@evgeniiz321 @roman-khimov @AliceInHunterland