Upgrade minimum required Go version to 1.20
#2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Feb 27, 2024
•
cthulhu-rider
commented
- blocked by Update to Go 1.20 min neofs-sdk-go#553
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
cthulhu-rider
force-pushed
the
2251-byte-clone
branch
from
c8de255
to
ac5b722
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2754 +/- ##
==========================================
- Coverage 28.65% 21.89% -6.76%
==========================================
Files 427 787 +360
Lines 33109 46643 +13534
==========================================
+ Hits 9486 10213 +727
- Misses 22771 35554 +12783
- Partials 852 876 +24 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
force-pushed
the
2251-byte-clone
branch
2 times, most recently
from
219f159
to
3710b3a
Compare
cthulhu-rider
force-pushed
the
2251-byte-clone
branch
from
3710b3a
to
1dfc3ba
Compare
done |
roman-khimov
approved these changes
Feb 29, 2024
|
Conflicts. |
cthulhu-rider
force-pushed
the
2251-byte-clone
branch
from
1dfc3ba
to
c6eb506
Compare
carpawell
reviewed
Feb 29, 2024
|
Conflicts now. |
Go 1.22 was recently released. As always, we require minimum version before last. Functionality of stdlib `math/rand` package was marked as deprecated, but used for test code only. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
New stdlib function was introduced in Go 1.20. It completely replaces the previously used `slice.Copy` utility. Manual `make`+`copy` no longer needed too. Closes #2251. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Starting from 1.20, std Go error system supports wrapping of multiple errors. This allows to: * wrap several errors using `fmt.Errorf`; * get rid of error-wrapping types like `logicerr.Logical`. Closes #2250. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
`status.Code` function supports wrapped errors, so it's redundant to do `errors.Unwrap` before. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
NeoFS SDK is full friendly with Go std error system used in `errors` package. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
2251-byte-clone
branch
from
c6eb506
to
2ff412c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.