workflows: build arm64/darwin binaries #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniiz321
reviewed
Apr 27, 2024
| @@ -37,8 +37,8 @@ jobs: | |||
| runs-on: ${{matrix.os.name}} | |||
| strategy: | |||
| matrix: | |||
| os: [{ name: ubuntu-22.04, bin-name: linux }] # { name: windows-2022, bin-name: windows }, { name: macos-12, bin-name: darwin } | |||
| arch: [amd64] # arm64 | |||
| os: [{ name: ubuntu-22.04, bin-name: linux }, { name: macos-14, bin-name: darwin }] # { name: windows-2022, bin-name: windows } | |||
There was a problem hiding this comment.
For neo-go we use macos-12 - https://github.com/nspcc-dev/neo-go/blob/master/.github/workflows/build.yml#L40
There was a problem hiding this comment.
fun fact, macos-12 runs on x86, macos-14 on arm, so I guess macos-14 is the correct one
There was a problem hiding this comment.
For builds it doesn't really matter, the resulting binary is determined by GOOS/GOARCH and you can build any binary on ubuntu-22.04 in fact (one of Go surprises).
roman-khimov
force-pushed
the
enable-darwin-arm64
branch
from
f086dd8
to
c993a2c
Compare
Related to #2824. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
enable-darwin-arm64
branch
from
c993a2c
to
b74a9fc
Compare
carpawell
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2824.