New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong guid generation #592

Closed
ikkeps opened this Issue Jun 16, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@ikkeps
Copy link

ikkeps commented Jun 16, 2015

In production we suddenly expiriencing lots of message duplication messages with about hundred of nsqd nodes. After looking at the code we realized that guid was improperly generated for worker ids >= 1024. see https://github.com/bitly/nsq/blob/master/nsqd/guid.go#L19 . Worker id has range 0-4095, while there are only ten bits shift between it and timestamp.

@jehiah

This comment has been minimized.

Copy link
Member

jehiah commented Jun 16, 2015

@ikkeps you are correct that there is/was an issue with values > 1024. That's been fixed in #586

@ikkeps

This comment has been minimized.

Copy link

ikkeps commented Jun 16, 2015

Oh, sorry, did not noticed that. Thanks for such fast reply!

@jehiah jehiah closed this Jun 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment