nsqd: ensure all Notify() goroutines have completed prior to shutdown #493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #491 ... I have been unable to reproduce the fairly regular panics since adding this fix. Note that I had to register the channel/topic notifications with the root nsqd waitGroup - while the channels and topics have their own waitGroups, those are waited on during their exit() methods. Since nsqd's Exit() method owns the nsqd Lock when it closes the topics, those topics deadlock if they had to wait on any pending Notify().
Ready for review.