nsqd: ensure all Notify() goroutines have completed prior to shutdown #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I guess that was pretty straightforward. My only issue is that I don't think these "children" of Feels like a better abstraction to me. What do you think? |
|
I've updated the PR with the cleaner abstraction; thanks for the feedback - still getting used to a language with minimal access levels / just package-level encapsulation :) I also incorporated Jehiah's suggestion for the temp file name randomization mentioned in #491 per our discussion in IRC yesterday. Ready for review again. |
|
LGTM, want to squash? |
… and prevent possible atomic_rename panics in Windows test suite * channel and topic changes now call nsqd.Notify() syncrhonously, and nsqd is responsible for spawning goroutines that will be tracked in its waitGroup for completion prior to exit. * nsqd's PersistMetadata uses a random temp filename to reduce the risk of concurrent tests stepping on each other
allgeek
force-pushed
the
windows_atomic_rename_panic_491
branch
from
4f178d3
to
b8c74b1
Compare
|
Squashed! Ready for review (hopefully for good this time!) |
|
nice work, thanks @allgeek |
mreiferson
added a commit
that referenced
this pull request
Nov 7, 2014
nsqd: ensure all Notify() goroutines have completed prior to shutdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #491 ... I have been unable to reproduce the fairly regular panics since adding this fix. Note that I had to register the channel/topic notifications with the root nsqd waitGroup - while the channels and topics have their own waitGroups, those are waited on during their exit() methods. Since nsqd's Exit() method owns the nsqd Lock when it closes the topics, those topics deadlock if they had to wait on any pending Notify().
Ready for review.