Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing memory allocations #111

Merged
merged 6 commits into from Aug 24, 2019

Conversation

@tpodolak
Copy link
Member

tpodolak commented Jul 7, 2019

Closes #115
Closes #59
C# - before

Method Mean Error StdDev Median Gen 0 Gen 1 Allocated
CallInfoAnalyzer 1,888.2 us 38.127 us 42.378 us 1,866.9 us 136.7188 11.7188 424.54 KB
ConflictingArgumentAssignmentsAnalyzer 576.8 us 11.593 us 33.819 us 561.2 us 33.2031 1.9531 103.47 KB
NonSubstitutableMemberAnalyzer 2,369.6 us 11.588 us 10.839 us 2,368.9 us 179.6875 15.6250 560.32 KB
NonSubstitutableMemberReceivedAnalyzer 627.3 us 2.087 us 1.952 us 626.7 us 31.2500 6.8359 96.27 KB
NonSubstitutableMemberWhenAnalyzer 974.5 us 3.510 us 3.112 us 975.2 us 37.1094 7.8125 116.74 KB
ReEntrantSetupAnalyzer 55,818.0 us 127.719 us 106.651 us 55,800.6 us 2333.3333 - 7178.25 KB
SubstituteAnalyzer 1,852.4 us 4.899 us 4.583 us 1,852.9 us 89.8438 21.4844 343.67 KB
UnusedReceivedAnalyzer 506.3 us 2.508 us 2.346 us 506.3 us 29.2969 1.9531 92.45 KB

C# after

Method Mean Error StdDev Gen 0 Gen 1 Allocated
CallInfoAnalyzer 1,664.3 us 6.397 us 5.671 us 119.1406 13.6719 366.89 KB
ConflictingArgumentAssignmentsAnalyzer 515.7 us 2.046 us 1.914 us 33.2031 1.9531 102.76 KB
NonSubstitutableMemberAnalyzer 758.6 us 6.060 us 5.372 us 39.0625 8.7891 122.27 KB
NonSubstitutableMemberReceivedAnalyzer 593.9 us 2.583 us 2.290 us 27.3438 5.8594 84.79 KB
NonSubstitutableMemberWhenAnalyzer 935.3 us 2.597 us 2.429 us 33.2031 9.7656 104.99 KB
ReEntrantSetupAnalyzer 7,231.7 us 36.044 us 30.099 us 281.2500 15.6250 870.18 KB
SubstituteAnalyzer 1,808.4 us 8.793 us 7.794 us 87.8906 23.4375 330.09 KB
UnusedReceivedAnalyzer 470.2 us 1.277 us 1.066 us 25.8789 1.9531 80.96 KB

|

VB - before

Method Mean Error StdDev Median Gen 0 Gen 1 Allocated
CallInfoAnalyzer 3.357 ms 0.0666 ms 0.0997 ms 3.304 ms 156.2500 11.7188 492.15 KB
ConflictingArgumentAssignmentsAnalyzer 1.531 ms 0.0321 ms 0.0439 ms 1.523 ms 21.4844 1.9531 69.15 KB
NonSubstitutableMemberAnalyzer 2.434 ms 0.0496 ms 0.0663 ms 2.414 ms 35.1563 7.8125 108 KB
NonSubstitutableMemberReceivedAnalyzer 1.544 ms 0.0297 ms 0.0396 ms 1.529 ms 13.6719 1.9531 47.46 KB
NonSubstitutableMemberWhenAnalyzer 1.888 ms 0.0327 ms 0.0306 ms 1.888 ms 25.3906 5.8594 82.72 KB
ReEntrantSetupAnalyzer 61.091 ms 0.8456 ms 0.7496 ms 61.014 ms 3555.5556 - 11141.26 KB
SubstituteAnalyzer 3.934 ms 0.1160 ms 0.3421 ms 4.055 ms 109.3750 23.4375 393.13 KB
UnusedReceivedAnalyzer 1.231 ms 0.0282 ms 0.0809 ms 1.223 ms 13.6719 1.9531 43.3 KB

VB - after

Method Mean Error StdDev Gen 0 Gen 1 Allocated
CallInfoAnalyzer 3.104 ms 0.0340 ms 0.0318 ms 148.4375 11.7188 458.6 KB
ConflictingArgumentAssignmentsAnalyzer 1.215 ms 0.0102 ms 0.0095 ms 21.4844 1.9531 68.36 KB
NonSubstitutableMemberAnalyzer 1.476 ms 0.0067 ms 0.0056 ms 25.3906 5.8594 81 KB
NonSubstitutableMemberReceivedAnalyzer 1.171 ms 0.0031 ms 0.0027 ms 11.7188 1.9531 44.4 KB
NonSubstitutableMemberWhenAnalyzer 1.453 ms 0.0091 ms 0.0085 ms 25.3906 5.8594 80.59 KB
ReEntrantSetupAnalyzer 6.878 ms 0.0395 ms 0.0369 ms 265.6250 7.8125 837.14 KB
SubstituteAnalyzer 3.137 ms 0.0166 ms 0.0147 ms 101.5625 23.4375 377.16 KB
UnusedReceivedAnalyzer 1.088 ms 0.0043 ms 0.0038 ms 11.7188 - 40.24 KB
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 7, 2019

@tpodolak tpodolak force-pushed the perf branch 2 times, most recently from ce10fab to 6cc6201 Jul 21, 2019
@tpodolak tpodolak force-pushed the perf branch from 6cc6201 to a4e3466 Aug 4, 2019
@tpodolak tpodolak changed the title WIP: Reducing memory allocations Reducing memory allocations Aug 24, 2019
@tpodolak tpodolak marked this pull request as ready for review Aug 24, 2019
@tpodolak tpodolak merged commit 2e23d39 into dev Aug 24, 2019
2 checks passed
2 checks passed
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@tpodolak tpodolak deleted the perf branch Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.