New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 77 PR #94

Merged
merged 4 commits into from Dec 29, 2012

Conversation

Projects
None yet
2 participants
@robdmoore
Contributor

robdmoore commented Dec 29, 2012

As per Issue 77 thread comment...

robdmoore added some commits Dec 29, 2012

Added a range of tests to expose some problems with the current appro…
…ach to fix GH-77

In order to allow for this approach to work correctly, GH-26 will need to be fixed
Reverting the current implementation for the GH-77 fix
This commit should probably be reverted if GH-26 is fixed and the ability to mock .Equals, .GetHashCode and .ToString is added or if partial mocking support is added (GH-93)

This is essentially reverting these two commits:
    SHA-1: 78a2348
    SHA-1: 754dccc
Any base object method call is now no longer proxied at all - this fixes
 GH-77, but doesn't give the ability to mock those methods

@dtchepak dtchepak merged commit 741fbac into nsubstitute:master Dec 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment