New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown table not rendered #1557

Closed
amueller opened this Issue Mar 16, 2017 · 17 comments

Comments

Projects
None yet
5 participants
@amueller
Copy link

amueller commented Mar 16, 2017

| Age | Number of Cars owned | Owns House | Number of Children| Marital status (s/m/d/w) | Owns a dog | Bought a Boat|
|-|-|-|-|-|-|-|
|66|1|y|2|w|n|y|
|52|2|y|3|m|n|y|
|22|0|n|0|m|y|n|
|25|1|n|1|s|n|n|
|44|0|n|2|d|y|n|
|39|1|y|2|m|y|n|
|26|1|n|2|s|n|n|
|40|3|y|1|m|y|n|
|53|2|y|2|d|n|y|
|64|2|y|3|d|n|n|
|58|2|y|2|m|y|y|
|33|1|n|1|s|n|n|

image

@rgbkrk

This comment has been minimized.

Copy link
Member

rgbkrk commented Mar 16, 2017

Now that GitHub released a formal spec for GitHub flavored Markdown we'll likely adopt it, which would include tables. There's not a JavaScript implementation that is compliant yet (this one is written in C), I'm looking forward to it though!

@amueller

This comment has been minimized.

Copy link

amueller commented Mar 16, 2017

What does Jupyter Notebook use? I think aiming at being as compatible as reasonably possible would be good. This renders fine in Jupyter.

@amueller

This comment has been minimized.

Copy link

amueller commented Mar 16, 2017

I know in the backend jupyter uses pandoc but not for browser stuff, right?

@amueller

This comment has been minimized.

Copy link

amueller commented Mar 16, 2017

somewhat off-topic: I would like my notebooks to have a layout language that allows me to refer to the input or output of a cell and to sections in the text. I want a cell to be able to say "see In[10]" in a dynamic way, or refer to sections. Markdown doesn't allow that and I think GFM doesn't allow that either.
It's a pretty big limitation imho :-/
[Oh and I don't want to hack this with html because I want my latex conversions to also work and not just drop it]

@rgbkrk

This comment has been minimized.

Copy link
Member

rgbkrk commented Mar 16, 2017

I know in the backend jupyter uses pandoc but not for browser stuff, right?

That's mostly correct, depends on what's being used in nbconvert.

What does Jupyter Notebook use?

Jupyter notebook uses marked, which is not as maintained as we would like it to be. It also has subtle differences with the spec for commonmark (ex-standard markdown). We're discussing the future in Jupyter there as well and want to be as close to the formal specification for commonmark as well.

@rgbkrk

This comment has been minimized.

Copy link
Member

rgbkrk commented Mar 16, 2017

I would like my notebooks to have a layout language that allows me to refer to the input or output of a cell and to sections in the text

Me too! We'll need a totally separate notebook format for that though. No time for me personally to charter or implement that.

@amueller

This comment has been minimized.

Copy link

amueller commented Mar 16, 2017

Ok. My point is mostly: I like for stuff to look the same in nteract as it does in Jupyter Notebooks. I'm not sure what the timeline is for the GFM implementation in JavaScript but I think it would be good to prioritize this to make transition from Jupyter Notebooks as easy as possible.

@ProgramFan

This comment has been minimized.

Copy link

ProgramFan commented Mar 21, 2017

How about integrating commonmark-table-extension https://github.com/webuni/commonmark-table-extension?

@jdetle

This comment has been minimized.

Copy link
Member

jdetle commented Mar 21, 2017

^ It seems this is for PHP? I don't know how we'd port that extension to javascript.

@ProgramFan

This comment has been minimized.

Copy link

ProgramFan commented Mar 21, 2017

Sorry to have made the mistake. For pure JS implementation, Remarkable looks promissing. It support full GFM. Tables are handled. It also brings syntax highlighting for code blocks.

@jdetle

This comment has been minimized.

Copy link
Member

jdetle commented Mar 21, 2017

@ProgramFan are you a student at an accredited university? A proposal for a Google Summer of Code project to make nteract conform with the jupyter notebook would be great.

@ProgramFan

This comment has been minimized.

Copy link

ProgramFan commented Mar 21, 2017

Unfortunately not any more 😃 @jdetle. I work full time as an associate professor and jupyter helps me a lot with my research, and I find nteract such a lovely tool. I like the proposal but just have not yet found the time. Maybe I can persuade some one to try it.

@jdetle

This comment has been minimized.

Copy link
Member

jdetle commented Mar 21, 2017

If you find a graduate or undergraduate student who is interested in programming please encourage them to apply as soon as possible! Thanks!

Link: https://github.com/nteract/nteract/wiki/Google-Summer-of-Code

@ProgramFan

This comment has been minimized.

Copy link

ProgramFan commented Mar 21, 2017

Of course.

@SCR1

This comment has been minimized.

Copy link

SCR1 commented Oct 27, 2017

I'm having the same issue.

@rgbkrk

This comment has been minimized.

Copy link
Member

rgbkrk commented Jan 31, 2018

Closed by #2350.

@rgbkrk rgbkrk closed this Jan 31, 2018

@lock

This comment has been minimized.

Copy link

lock bot commented May 1, 2018

Howdy! I'm 🔓🤖!

In order to keep information timely (based on the most recent release), we want all activity to be added to either new issues or open issues and PRs. In service to that goal, I, the lock bot close inactive closed issues when they haven't had activity in 120 days.

Feel free to open a new issue for related bugs and link to relevant comments from this thread.

@lock lock bot locked and limited conversation to collaborators May 1, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.