New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract transforms for lerna #1420
Extract transforms for lerna #1420
Conversation
f98a330
to
6f72b6d
Compare
rebased, for starters. |
"@nteract/transform-model-debug": "1.0.0", | ||
"@nteract/transform-plotly": "1.0.0", | ||
"@nteract/transform-vega": "1.0.0", | ||
"@nteract/transforms": "1.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ this is definitely moving along
Tests pass for me locally, let's see what our CI pals have to say about it. |
Oh, I think it's because I ran lerna locally, which CI doesn't yet know about. Let me add that. |
I think the flow errors we're seeing are similar to some of the issues reported on this thread: immutable-js/immutable-js#203 but I have not followed it all to figure out how to get around it. |
I don't really know how flow works, but might it have something to do with the fact that we have 3 copies / version of immutable.js?
so the lerna-ed packages reference their own, but the main app references its own, and flow doesn't understand that they're the same? |
I'm looking at the flow types for Immutable and the
A deeply nested value may not actually be @peggyrayzis what's the best way for us to ignore bad parts of definitions that come as part of the library (not in our |
Then again, this was passing on master. Have you run into anything like this @thejameskyle or @hzoo? We're trying to adapt to using lerna (amidst shipping an Electron app), running into trouble with the flow definitions for Immutable. |
For what it's worth, I get the same flow error on master. :\ |
Ok, so here's how the errors can be eliminated: except I think there's a bug in lerna, because running that with the symlinking the root |
Codecov Report@@ Coverage Diff @@
## master #1420 +/- ##
==========================================
+ Coverage 90.42% 90.44% +0.01%
==========================================
Files 66 67 +1
Lines 1724 1726 +2
==========================================
+ Hits 1559 1561 +2
Misses 165 165 Continue to review full report at Codecov.
|
It looks like Paul already fixed the issue, but I would put a line in the [ignore] section of |
Ah, that must be because you and I have both done a |
Tried it, didn't work. 😭 |
I wonder if this is because we listed it as a dev dependency: We could switch back to a normal dependency, the reason I didn't want to go that route was so that people could rely on it as a peer dependency. |
I'm trying some things and will post a new commit when I think it's in a friendly state. |
It passes! 🔨 |
package.json
Outdated
@@ -31,7 +31,7 @@ | |||
"lint": "eslint src/ test/", | |||
"lint:fix": "eslint . --fix", | |||
"prebuild": "rimraf lib", | |||
"lerna": "lerna bootstrap --hoist immutable", | |||
"lerna": "lerna bootstrap && rimraf packages/commutable/node_modules/immutable", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a stopgap for us until the next lerna release (which will probably be today).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeap, I opened #1436 so we remember to do it in case lerna release gets held up.
Whoops, because of me there's a merge conflict with the geojson transform. I'll handle that now. |
fix typo in transforms-mode-debug package.json name
maybe CI will have better luck than what I get here.
ba9454e
to
28ee93d
Compare
Rebased, brought in the background color -> GeoJSON tile support. |
Yay, new lerna release fixes it for us! Thanks all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great to me! I'm excited to start working on exporting packages 🎉
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Extract our transforms from media type payloads ➡️ React Elements.