Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing API for Bookstore #4451

Open
wants to merge 1 commit into
base: master
from

Conversation

1 participant
@stormpython
Copy link
Member

commented Jun 14, 2019

Closes #4450.

I removed the bookstore key from the payload, and I changed the way I am checking to see if bookstore is available. I have questions around the latter since I am not sure its the best solution.

Shelby Sturgis
Changing API for bookstore connection. I removed the key from the pay…
…load, and I changed the way I am checking to see if bookstore is available. There are questions I have around the latter since I am not sure its the best solution.
@@ -44,7 +44,7 @@ export async function main(
token: config.token,
origin: location.origin,
basePath: config.baseUrl,
bookstoreEnabled: config.bookstore.enabled,
bookstoreEnabled: !!config.bookstore.version,

This comment has been minimized.

Copy link
@stormpython

stormpython Jun 14, 2019

Author Member

I think there is a better way to do this. However, I am not sure what happens when we make a call to Bookstore and get a 404 back. Do we still get an object? Is that object empty?

Also I know the double bangs are not great to do stylistically. So I am happy to change this once I have a better understanding of what payload I get back.

@stormpython stormpython requested a review from mpacer Jun 14, 2019

@stormpython stormpython self-assigned this Jun 14, 2019

@stormpython stormpython added this to In progress in Publish to Bookstore/S3 via automation Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.