Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ordering of cell toolbar and notifications #4456

Merged
merged 1 commit into from Jun 17, 2019

Conversation

Projects
None yet
2 participants
@rganardi
Copy link
Contributor

commented Jun 16, 2019

Fixes #4404.

The cell toolbar appears over the notification element, so reorder the z-index so the elements appear in the right order

notification
toolbar
cell

@rgbkrk

rgbkrk approved these changes Jun 17, 2019

Copy link
Member

left a comment

Thank you, this is a pragmatic solution that I've punted on while waiting for us to come back to looking at our stacking contexts and an explicit z index hierarchy. 👌

@rgbkrk rgbkrk merged commit ea10484 into nteract:master Jun 17, 2019

3 checks passed

WIP Ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
nteract.nteract #20190616.1 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.