Skip to content

Conversation

@willingc
Copy link
Member

Addresses #4415

@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #4996 (dfd5bb3) into master (4998345) will increase coverage by 1.47%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #4996      +/-   ##
==========================================
+ Coverage   71.05%   72.53%   +1.47%     
==========================================
  Files         235      204      -31     
  Lines        5293     5702     +409     
  Branches      778      874      +96     
==========================================
+ Hits         3761     4136     +375     
+ Misses       1265     1206      -59     
- Partials      267      360      +93     

@captainsafia
Copy link
Member

@willingc What else do we need to do so that this PR is mergeable?

@willingc
Copy link
Member Author

@captainsafia I think that we need to fix a wider issue with autocomplete. It wasn't working with the Python kernel.

@captainsafia
Copy link
Member

@willingc Do you get completions when you type Ctrl-Space in the editor? Typeahead completions were temporarily moved a while back since a lot of users found them arbitrary and annoying and we didn't have a configurability layer for it.

ramantehlan and others added 26 commits August 6, 2020 01:12
[nteract/web] Save/upload to Github and other improvements.
[nteract/web] Add project details in main and landing page
…kernel

Fix the logic getting the default kernel
…-4.x

Update dependency @nteract/mathjax to v4.0.10
captainsafia and others added 20 commits November 29, 2020 20:14
Fix processing of kernelspecs request
…-4.x

Update dependency @nteract/mathjax to v4.0.14
Bump @nteract/jupyter-widgets dependency
 - nteract@0.27.0
 - @nteract/nbextension@1.13.0
 - @nteract/web@1.2.0
 - nteract-on-jupyter@2.13.0
 - @nteract/actions@7.0.5
 - @nteract/commutable@7.3.5
 - @nteract/connected-components@6.8.5
 - @nteract/core@15.1.3
 - @nteract/editor@10.1.5
 - @nteract/epics@5.0.5
 - @nteract/fixtures@2.3.13
 - @mybinder/host-cache@2.1.30
 - @nteract/messaging@7.0.13
 - @nteract/monaco-editor@3.2.3
 - @nteract/mythic-configuration@1.0.5
 - @nteract/mythic-multiselect@0.0.6
 - @nteract/mythic-notifications@0.2.5
 - @nteract/mythic-windowing@0.1.1
 - @nteract/myths@0.2.5
 - @nteract/notebook-app-component@7.7.3
 - @nteract/presentational-components@3.4.5
 - @nteract/reducers@5.1.3
 - rx-binder@4.0.9
 - rx-jupyter@5.5.15
 - @nteract/selectors@3.1.3
 - @nteract/stateful-components@1.7.3
 - @nteract/styles@2.2.5
 - @nteract/types@7.1.3
 - @nteract/webpack-configurator@3.1.20
…ncies

Remove electron dependency from mythic-notifications
 - nteract@0.27.1
 - @nteract/nbextension@1.13.1
 - @nteract/web@1.2.1
 - nteract-on-jupyter@2.13.1
 - @nteract/actions@7.0.6
 - @nteract/commutable@7.4.0
 - @nteract/connected-components@6.8.6
 - @nteract/core@15.1.4
 - @nteract/editor@10.1.6
 - @nteract/epics@5.0.6
 - @nteract/fixtures@2.3.14
 - @mybinder/host-cache@2.1.31
 - @nteract/messaging@7.0.14
 - @nteract/monaco-editor@3.2.4
 - @nteract/mythic-configuration@1.0.6
 - @nteract/mythic-multiselect@0.0.7
 - @nteract/mythic-notifications@0.2.6
 - @nteract/mythic-windowing@0.1.2
 - @nteract/myths@0.2.6
 - @nteract/notebook-app-component@7.7.4
 - @nteract/presentational-components@3.4.6
 - @nteract/reducers@5.1.4
 - rx-binder@4.0.10
 - rx-jupyter@5.5.16
 - @nteract/selectors@3.1.4
 - @nteract/stateful-components@1.7.4
 - @nteract/styles@2.2.6
 - @nteract/types@7.1.4
 - @nteract/webpack-configurator@3.1.21
Update dependency @types/codemirror to ^0.0.101
Update dependency @types/codemirror to ^0.0.102
…rettier-7.x

Update dependency eslint-config-prettier to v7
@lgtm-com
Copy link

lgtm-com bot commented Dec 8, 2020

This pull request introduces 5 alerts and fixes 5 when merging 1a7ea40 into 4998345 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

fixed alerts:

  • 5 for Unused variable, import, function or class

@willingc willingc force-pushed the autocomplete branch 2 times, most recently from 55ec5db to bfc813f Compare December 8, 2020 15:12
@willingc
Copy link
Member Author

willingc commented Dec 8, 2020

Closing since the solution isn't correct and the rebase mucked things up.

@willingc willingc closed this Dec 8, 2020
@willingc willingc deleted the autocomplete branch December 8, 2020 15:20
@lgtm-com
Copy link

lgtm-com bot commented Dec 8, 2020

This pull request introduces 5 alerts and fixes 5 when merging 8227215 into 4998345 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

fixed alerts:

  • 5 for Unused variable, import, function or class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.