Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the "ipython" requirement to requirements-dev.txt #370

Closed
tsvikas opened this issue May 27, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@tsvikas
Copy link

commented May 27, 2019

I believe that, to load, change, execute & save jupyter notebooks, the dependency on ipython is unnecessary.

In my checks, nbformat, nbconvert & jupyter_client are required, but ipython is not. Since this package has a bunch of dependencies itself, removing it will allow much leaner dependency tree.

However, some of the notebooks that are used in the tests are importing IPython, so they need to run in an environment that contains ipython. As far as I know, the best practice to do that is to add ipython to requirement-dev.txt (alternatively, to create an optional extra dependency papermill[tests], or to remove IPython from the test notebooks).

@MSeal

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Good call, yes that's a preferable change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.