Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves imports to be lazy which pull in IPython #380

Merged
merged 1 commit into from Jun 26, 2019

Conversation

Projects
None yet
2 participants
@MSeal
Copy link
Member

commented Jun 13, 2019

This saves substantially on initial load times for papermill, and reduces initial execution latency if progress bars are turned off.

print(pip_message, file=sys.stderr)
sys.exit(1)


This comment has been minimized.

Copy link
@rgbkrk

rgbkrk Jun 26, 2019

Member

This was for an old version of pip and previously needing IPython on start, so it makes sense to remove this. 👍

@rgbkrk

rgbkrk approved these changes Jun 26, 2019

@rgbkrk rgbkrk merged commit fc3e7a8 into nteract:master Jun 26, 2019

2 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.