New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deepcopy #694
Remove deepcopy #694
Conversation
Just found this one after updating something internal and hitting serialization issue again. See previous PR regarding deepcopy (they have no purpose).
There is a purpose to deepcopy, in the interface, but I agree removing it should be expected at this point. Very early on there was more manipulation of nbformat objects and some implicit expectations that the input wouldn't be modified. Mostly when scrapbook code was still part of papermill. Not as much of a concern now-a-days so happy to merge it. |
Engine input isolation removed, update test with deepcopy.
Head branch was pushed to by a user without write access
Remove test with this expectation.
I figured I could quickly update this in browser, I'll wait till I'm home later today to actually pull everything down and run the tests locally before committing anything else to the branch. |
Used deepcopy where necessary when tests used the isolated nb expectation in unittest logic for assertion checks.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
- Coverage 91.86% 91.86% -0.01%
==========================================
Files 17 17
Lines 1623 1622 -1
==========================================
- Hits 1491 1490 -1
Misses 132 132
Continue to review full report at Codecov.
|
@MSeal Can this be merged? Thanks. |
Just found this one after updating something internal and hitting serialization issue again. See previous PR regarding deepcopy (they have no purpose).