Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ChangeLog date instead of build date #662

Merged
merged 1 commit into from Mar 23, 2019

Conversation

@bmwiedemann
Copy link
Contributor

commented Jan 24, 2019

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good.

This date call works with GNU date and BSD date.
Also use UTC/gmtime to be independent of timezone.

This PR was done while working on reproducible builds for openSUSE.

Use ChangeLog date instead of build date
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good.

This date call works with GNU date and BSD date.
Also use UTC/gmtime to be independent of timezone.
@bmwiedemann

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

ping. Is there anything I can do to help get this simple patch merged?
We could also do alternative patches using SOURCE_DATE_EPOCH

@lucaderi lucaderi merged commit e6f8a66 into ntop:dev Mar 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lucaderi

This comment has been minimized.

Copy link
Member

commented Mar 23, 2019

Thank you

@bmwiedemann bmwiedemann deleted the bmwiedemann:date branch Mar 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.