Add setuptools and rpm setup capabilities #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setuptools with pbr used for python packages such as masakari-controller and masakari-instancemoniror. For, shell scripts in masakari-processmonitor and masakari-hostmonitor uses spec file to build rpms.
logger only create the log file but not the path. Need to create the path if not exist.
Add spec files to each masakari-* to build rpms. Add systemd scripts to control the services.
Add howtobuild_rpms files. TODO: fill them out
Fix spec file for masakari-instancemonitor
How to setup masakari-controller How to build rpms from source Add python-novaclient to requirements
|
To test this code, |
|
Overall, LGTM. If possible, could you surround commands in README with |
|
@muroi Thank you for the review. |
|
looks good to me. Just need to resolve conflicts. |
|
Conflicts resolved |
|
#18 and this PR add .gitignore file but file content is slightly different. |
muroi
added a commit
that referenced
this pull request
Mar 16, 2016
Add setuptools and rpm setup capabilities Close #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add setuptools and rpm setup capabilities to masakari
Implement setuptools with pbr packaging feature for,
masakari-controller and masakari-instancemonitor.
rpm spec files for each project and located under,
[project_name]/rpmbuild/SPECS/*.spec
systemd scripts are under,
[project_name]/etc/systemd/system/[project_name].service