From 9c5d63894d9680892bc2495cb570b308b90c1a64 Mon Sep 17 00:00:00 2001
From: Tatsuki3939 <tatsuki.sakai@ntt.com>
Date: Thu, 28 Sep 2023 10:10:43 +0900
Subject: [PATCH] feat: Modified get by HTTT to refer to device config

---
 internal/core/serve_http.go | 23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/internal/core/serve_http.go b/internal/core/serve_http.go
index f95a2f6..d092fb6 100644
--- a/internal/core/serve_http.go
+++ b/internal/core/serve_http.go
@@ -30,6 +30,7 @@ import (
 	"net/http"
 	"os"
 	"path/filepath"
+	"strings"
 
 	"cuelang.org/go/cue"
 	"cuelang.org/go/cue/cuecontext"
@@ -41,6 +42,11 @@ import (
 	"github.com/nttcom/kuesta/pkg/kuesta"
 )
 
+const (
+	ServiceKind = "services"
+	DeviceKind  = "devices"
+)
+
 type HttpGetBody struct {
 	Paths []string `json:"paths"`
 }
@@ -99,12 +105,25 @@ func HttpGet(c echo.Context, rootpath string) error {
 	c.Logger().Info("get called for http")
 	req := HttpGetBody{}
 	if err := c.Bind(&req); err != nil {
-		return echo.NewHTTPError(http.StatusBadRequest, fmt.Sprintf("HttpGet Please provide valid credentials: %v", err))
+		return echo.NewHTTPError(http.StatusBadRequest, fmt.Sprintf("HttpGet error: Bind: %v", err))
 	}
 
 	res := make([]interface{}, 0)
 	for _, v := range req.Paths {
-		path := filepath.Clean(filepath.Join(rootpath, v, "input.cue"))
+		pathElms := strings.Split(filepath.Clean(v), "/")
+		if len(pathElms) < 2 {
+			return echo.NewHTTPError(http.StatusBadRequest, fmt.Sprintf("HttpGet error: not expected path %v", v))
+		}
+		rfile := ""
+		switch pathElms[1] {
+		case ServiceKind:
+			rfile = "input.cue"
+		case DeviceKind:
+			rfile = "config.cue"
+		default:
+			return echo.NewHTTPError(http.StatusBadRequest, fmt.Sprintf("HttpGet error: not expected kind %v", pathElms[1]))
+		}
+		path := filepath.Clean(filepath.Join(rootpath, v, rfile))
 		buf, err := os.ReadFile(path)
 		if err != nil {
 			return echo.NewHTTPError(http.StatusBadRequest, fmt.Sprintf("HttpGet error: ReadFile: %v", err))