From adbbad4425c20651dc3c76b66cb9a9c6127443f7 Mon Sep 17 00:00:00 2001 From: ntziolis Date: Thu, 22 Mar 2012 01:25:36 +0100 Subject: [PATCH] Unified ID naming and updated unit test --- AppHarbor.Net/AppHarborApi.cs | 183 +++++++++++++++++++++------- AppHarbor.Net/Model/CreateResult.cs | 2 +- AppHarbor.Test/MockedApiTests.cs | 50 +++++--- 3 files changed, 169 insertions(+), 66 deletions(-) diff --git a/AppHarbor.Net/AppHarborApi.cs b/AppHarbor.Net/AppHarborApi.cs index f3d4109..f0be923 100644 --- a/AppHarbor.Net/AppHarborApi.cs +++ b/AppHarbor.Net/AppHarborApi.cs @@ -29,6 +29,10 @@ public class AppHarborApi public static AuthInfo GetAuthInfo(string clientID, string clientSecret, string code) { + CheckArgumentNull("clientID", clientID); + CheckArgumentNull("clientSecret", clientSecret); + CheckArgumentNull("code", code); + // make POST request to obtain the token var client = new RestClient(BaseUrl); var request = new RestRequest(Method.POST); @@ -189,10 +193,10 @@ private CreateResult ExecuteCreate(RestRequest request,Func ext throw new ArgumentException("Response cannot be null."); if (response.StatusCode == System.Net.HttpStatusCode.Conflict) - return new CreateResult() { CreateStatus = CreateStatus.AlreadyExists }; + return new CreateResult() { Status = CreateStatus.AlreadyExists }; if (response.StatusCode != System.Net.HttpStatusCode.Created) - return new CreateResult() { CreateStatus = CreateStatus.Undefined }; + return new CreateResult() { Status = CreateStatus.Undefined }; var locationHeader = response.Headers .SingleOrDefault(p => string.Equals(p.Name, "Location", StringComparison.OrdinalIgnoreCase)); @@ -205,7 +209,7 @@ private CreateResult ExecuteCreate(RestRequest request,Func ext return new CreateResult() { - CreateStatus = Model.CreateStatus.Created, + Status = Model.CreateStatus.Created, ID = id, Location = location, }; @@ -229,6 +233,12 @@ private bool ExecuteDelete(RestRequest request) return (response.StatusCode == System.Net.HttpStatusCode.NoContent); } + private static void CheckArgumentNull(string argumentName, object value) + { + if (value == null) + throw new ArgumentNullException(argumentName); + } + #endregion #region Application @@ -243,14 +253,29 @@ public IList GetApplications() public Application GetApplication(string applicationID) { + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(); request.Resource = "applications/{applicationID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); return ExecuteGet(request); } - public CreateResult CreateApplication(string applicationID, string name, string regionIdentifier) + /// + /// Creates a new application + /// + /// Name of the application. + /// Region the application will be created at, will default to "amazon-web-services::us-east-1". + /// + public CreateResult CreateApplication(string name, string regionIdentifier) { + CheckArgumentNull("name", name); + + if (regionIdentifier == null) + regionIdentifier = "amazon-web-services::us-east-1"; + + CheckArgumentNull("regionIdentifier", regionIdentifier); + var request = new RestRequest(Method.POST); request.RequestFormat = DataFormat.Json; request.Resource = "applications"; @@ -265,6 +290,10 @@ public CreateResult CreateApplication(string applicationID, string name, public bool EditApplication(string applicationID, Application application) { + CheckArgumentNull("applicationID", applicationID); + CheckArgumentNull("application", application); + CheckArgumentNull("application.Name", application.Name); + var request = new RestRequest(Method.PUT); request.RequestFormat = DataFormat.Json; request.Resource = "applications/{applicationID}"; @@ -278,8 +307,9 @@ public bool EditApplication(string applicationID, Application application) public bool DeleteApplication(string applicationID) { - var request = new RestRequest(Method.DELETE); + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(Method.DELETE); request.Resource = "applications/{applicationID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); @@ -290,18 +320,22 @@ public bool DeleteApplication(string applicationID) #region Collaborator - public Collaborator GetCollaborator(string applicationID, long id) + public Collaborator GetCollaborator(string applicationID, long ID) { + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(); - request.Resource = "applications/{applicationID}/collaborators/{id}"; + request.Resource = "applications/{applicationID}/collaborators/{ID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); - request.AddParameter("id", id, ParameterType.UrlSegment); + request.AddParameter("ID", ID, ParameterType.UrlSegment); return ExecuteGetKeyed(request); } public IList GetCollaborators(string applicationID) { + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(); request.Resource = "applications/{applicationID}/collaborators"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); @@ -311,6 +345,12 @@ public IList GetCollaborators(string applicationID) public CreateResult CreateCollaborator(string applicationID, string email, CollaboratorType collaboratorType) { + CheckArgumentNull("applicationID", applicationID); + CheckArgumentNull("email", email); + + if (collaboratorType == CollaboratorType.None) + throw new ArgumentException("collaboratorType needs to be set."); + var request = new RestRequest(Method.POST); request.RequestFormat = DataFormat.Json; request.Resource = "applications/{applicationID}/collaborators"; @@ -325,11 +365,18 @@ public CreateResult CreateCollaborator(string applicationID, string email, public bool EditCollaborator(string applicationID, Collaborator collaborator) { + CheckArgumentNull("applicationID", applicationID); + CheckArgumentNull("collaborator", collaborator); + CheckArgumentNull("collaborator.Role", collaborator.Role); + + if (collaborator.Role == CollaboratorType.None) + throw new ArgumentException("collaborator.Role has to be set."); + var request = new RestRequest(Method.PUT); request.RequestFormat = DataFormat.Json; - request.Resource = "applications/{applicationID}/collaborators/{id}"; + request.Resource = "applications/{applicationID}/collaborators/{ID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); - request.AddParameter("id", collaborator.ID, ParameterType.UrlSegment); + request.AddParameter("ID", collaborator.ID, ParameterType.UrlSegment); request.AddBody(new { role = Util.GetCollaboratorType(collaborator.Role), @@ -337,13 +384,14 @@ public bool EditCollaborator(string applicationID, Collaborator collaborator) return ExecuteEdit(request); } - public bool DeleteCollaborator(string applicationID, long id) + public bool DeleteCollaborator(string applicationID, long ID) { - var request = new RestRequest(Method.DELETE); + CheckArgumentNull("applicationID", applicationID); - request.Resource = "applications/{applicationID}/collaborators/{id}"; + var request = new RestRequest(Method.DELETE); + request.Resource = "applications/{applicationID}/collaborators/{ID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); - request.AddParameter("id", id, ParameterType.UrlSegment); + request.AddParameter("ID", ID, ParameterType.UrlSegment); return ExecuteDelete(request); } @@ -352,18 +400,22 @@ public bool DeleteCollaborator(string applicationID, long id) #region ConfigurationVariable - public ConfigurationVariable GetConfigurationVariable(string applicationID, long id) + public ConfigurationVariable GetConfigurationVariable(string applicationID, long ID) { + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(); - request.Resource = "applications/{applicationID}/configurationvariables/{id}"; + request.Resource = "applications/{applicationID}/configurationvariables/{ID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); - request.AddParameter("id", id, ParameterType.UrlSegment); + request.AddParameter("ID", ID, ParameterType.UrlSegment); return ExecuteGetKeyed(request); } public IList GetConfigurationVariables(string applicationID) { + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(); request.Resource = "applications/{applicationID}/configurationvariables"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); @@ -373,6 +425,10 @@ public IList GetConfigurationVariables(string application public CreateResult CreateConfigurationVariable(string applicationID, string key, string value) { + CheckArgumentNull("applicationID", applicationID); + CheckArgumentNull("key", key); + CheckArgumentNull("value", value); + var request = new RestRequest(Method.POST); request.RequestFormat = DataFormat.Json; request.Resource = "applications/{applicationID}/configurationvariables"; @@ -387,11 +443,16 @@ public CreateResult CreateConfigurationVariable(string applicationID, stri public bool EditConfigurationVariable(string applicationID, ConfigurationVariable configurationVariable) { + CheckArgumentNull("applicationID", applicationID); + CheckArgumentNull("configurationVariable", configurationVariable); + CheckArgumentNull("configurationVariable.Key ", configurationVariable.Key); + CheckArgumentNull("configurationVariable.Value", configurationVariable.Value); + var request = new RestRequest(Method.PUT); request.RequestFormat = DataFormat.Json; - request.Resource = "applications/{applicationID}/configurationvariables/{id}"; + request.Resource = "applications/{applicationID}/configurationvariables/{ID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); - request.AddParameter("id", configurationVariable.ID, ParameterType.UrlSegment); + request.AddParameter("ID", configurationVariable.ID, ParameterType.UrlSegment); request.AddBody(new { key = configurationVariable.Key, @@ -400,13 +461,14 @@ public bool EditConfigurationVariable(string applicationID, ConfigurationVariabl return ExecuteEdit(request); } - public bool DeleteConfigurationVariable(string applicationID, long id) + public bool DeleteConfigurationVariable(string applicationID, long ID) { - var request = new RestRequest(Method.DELETE); + CheckArgumentNull("applicationID", applicationID); - request.Resource = "applications/{applicationID}/configurationvariables/{id}"; + var request = new RestRequest(Method.DELETE); + request.Resource = "applications/{applicationID}/configurationvariables/{ID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); - request.AddParameter("id", id, ParameterType.UrlSegment); + request.AddParameter("ID", ID, ParameterType.UrlSegment); return ExecuteDelete(request); } @@ -415,18 +477,22 @@ public bool DeleteConfigurationVariable(string applicationID, long id) #region Hostname - public Hostname GetHostname(string applicationID, long id) + public Hostname GetHostname(string applicationID, long ID) { + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(); - request.Resource = "applications/{applicationID}/hostnames/{id}"; + request.Resource = "applications/{applicationID}/hostnames/{ID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); - request.AddParameter("id", id, ParameterType.UrlSegment); + request.AddParameter("ID", ID, ParameterType.UrlSegment); return ExecuteGetKeyed(request); } public IList GetHostnames(string applicationID) { + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(); request.Resource = "applications/{applicationID}/hostnames"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); @@ -436,6 +502,9 @@ public IList GetHostnames(string applicationID) public CreateResult CreateHostname(string applicationID, string hostName) { + CheckArgumentNull("applicationID", applicationID); + CheckArgumentNull("hostName", hostName); + var request = new RestRequest(Method.POST); request.RequestFormat = DataFormat.Json; request.Resource = "applications/{applicationID}/hostnames"; @@ -447,13 +516,14 @@ public CreateResult CreateHostname(string applicationID, string hostName) return ExecuteCreate(request); } - public bool DeleteHostname(string applicationID, long id) + public bool DeleteHostname(string applicationID, long ID) { - var request = new RestRequest(Method.DELETE); + CheckArgumentNull("applicationID", applicationID); - request.Resource = "applications/{applicationID}/hostnames/{id}"; + var request = new RestRequest(Method.DELETE); + request.Resource = "applications/{applicationID}/hostnames/{ID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); - request.AddParameter("id", id, ParameterType.UrlSegment); + request.AddParameter("ID", ID, ParameterType.UrlSegment); return ExecuteDelete(request); } @@ -462,18 +532,22 @@ public bool DeleteHostname(string applicationID, long id) #region Servicehook - public ServiceHook GetServicehook(string applicationID, long id) + public ServiceHook GetServicehook(string applicationID, long ID) { + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(); - request.Resource = "applications/{applicationID}/servicehooks/{id}"; + request.Resource = "applications/{applicationID}/servicehooks/{ID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); - request.AddParameter("id", id, ParameterType.UrlSegment); + request.AddParameter("ID", ID, ParameterType.UrlSegment); return ExecuteGetKeyed(request); } public IList GetServicehooks(string applicationID) { + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(); request.Resource = "applications/{applicationID}/servicehooks"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); @@ -483,6 +557,9 @@ public IList GetServicehooks(string applicationID) public CreateResult CreateServicehook(string applicationID, string url) { + CheckArgumentNull("applicationID", applicationID); + CheckArgumentNull("url", url); + var request = new RestRequest(Method.POST); request.RequestFormat = DataFormat.Json; request.Resource = "applications/{applicationID}/servicehooks"; @@ -494,13 +571,14 @@ public CreateResult CreateServicehook(string applicationID, string url) return ExecuteCreate(request); } - public bool DeleteServicehook(string applicationID, long id) + public bool DeleteServicehook(string applicationID, long ID) { - var request = new RestRequest(Method.DELETE); + CheckArgumentNull("applicationID", applicationID); - request.Resource = "applications/{applicationID}/servicehooks/{id}"; + var request = new RestRequest(Method.DELETE); + request.Resource = "applications/{applicationID}/servicehooks/{ID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); - request.AddParameter("id", id, ParameterType.UrlSegment); + request.AddParameter("ID", ID, ParameterType.UrlSegment); return ExecuteDelete(request); } @@ -509,18 +587,22 @@ public bool DeleteServicehook(string applicationID, long id) #region Build - public Build GetBuild(string applicationID, long id) + public Build GetBuild(string applicationID, long ID) { + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(); - request.Resource = "applications/{applicationID}/builds/{id}"; + request.Resource = "applications/{applicationID}/builds/{ID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); - request.AddParameter("id", id, ParameterType.UrlSegment); + request.AddParameter("ID", ID, ParameterType.UrlSegment); return ExecuteGetKeyed(request); } public IList GetBuilds(string applicationID) { + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(); request.Resource = "applications/{applicationID}/builds"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); @@ -532,19 +614,24 @@ public IList GetBuilds(string applicationID) #region Test - public Test GetTest(string applicationID, long buildID, string id) + public Test GetTest(string applicationID, long buildID, string ID) { + CheckArgumentNull("applicationID", applicationID); + CheckArgumentNull("ID", ID); + var request = new RestRequest(); - request.Resource = "applications/{applicationID}/builds/{buildID}/tests/{id}"; + request.Resource = "applications/{applicationID}/builds/{buildID}/tests/{ID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); request.AddParameter("buildID", buildID, ParameterType.UrlSegment); - request.AddParameter("id", id, ParameterType.UrlSegment); + request.AddParameter("ID", ID, ParameterType.UrlSegment); return ExecuteGet(request); } public IList GetTests(string applicationID, long buildID) { + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(); request.Resource = "applications/{applicationID}/builds/{buildID}/tests"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); @@ -557,18 +644,22 @@ public IList GetTests(string applicationID, long buildID) #region Error - public Error GetError(string applicationID, long id) + public Error GetError(string applicationID, long ID) { + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(); - request.Resource = "applications/{applicationID}/errors/{id}"; + request.Resource = "applications/{applicationID}/errors/{ID}"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); - request.AddParameter("id", id, ParameterType.UrlSegment); + request.AddParameter("ID", ID, ParameterType.UrlSegment); return ExecuteGetKeyed(request); } public IList GetErrors(string applicationID) { + CheckArgumentNull("applicationID", applicationID); + var request = new RestRequest(); request.Resource = "applications/{applicationID}/errors"; request.AddParameter("applicationID", applicationID, ParameterType.UrlSegment); diff --git a/AppHarbor.Net/Model/CreateResult.cs b/AppHarbor.Net/Model/CreateResult.cs index 5fb6855..d85fbd7 100644 --- a/AppHarbor.Net/Model/CreateResult.cs +++ b/AppHarbor.Net/Model/CreateResult.cs @@ -7,7 +7,7 @@ namespace AppHarbor.Model { public class CreateResult { - public CreateStatus CreateStatus { get; set; } + public CreateStatus Status { get; set; } public T ID { get; set; } diff --git a/AppHarbor.Test/MockedApiTests.cs b/AppHarbor.Test/MockedApiTests.cs index 071fdf6..fe799b9 100644 --- a/AppHarbor.Test/MockedApiTests.cs +++ b/AppHarbor.Test/MockedApiTests.cs @@ -39,9 +39,9 @@ public void InitTest() [TestMethod] public void Create_Non_Existing_Application() { - var createResult = Api.CreateApplication(ApplicationId, ApplicationId, null); + var createResult = Api.CreateApplication(ApplicationId, null); Assert.IsNotNull(createResult); - Assert.AreEqual(AppHarbor.Model.CreateStatus.Created, createResult.CreateStatus); + Assert.AreEqual(AppHarbor.Model.CreateStatus.Created, createResult.Status); Assert.AreEqual(ApplicationId, createResult.ID); Assert.AreEqual("https://appharbor.com/applications/:application", createResult.Location); } @@ -49,9 +49,9 @@ public void Create_Non_Existing_Application() [TestMethod] public void Try_Create_Existing_Application() { - var createResult = ExistingDataDataApi.CreateApplication(ApplicationId, ApplicationId, null); + var createResult = ExistingDataDataApi.CreateApplication(ApplicationId, null); Assert.IsNotNull(createResult); - Assert.AreEqual(AppHarbor.Model.CreateStatus.AlreadyExists, createResult.CreateStatus); + Assert.AreEqual(AppHarbor.Model.CreateStatus.AlreadyExists, createResult.Status); Assert.AreEqual(null, createResult.ID); Assert.AreEqual(null, createResult.Location); } @@ -61,7 +61,7 @@ public void Create_Non_Existing_Collaborator() { var createResult = Api.CreateCollaborator(ApplicationId, "some@mail.com", Model.CollaboratorType.Collaborator); Assert.IsNotNull(createResult); - Assert.AreEqual(AppHarbor.Model.CreateStatus.Created, createResult.CreateStatus); + Assert.AreEqual(AppHarbor.Model.CreateStatus.Created, createResult.Status); Assert.AreEqual(5, createResult.ID); Assert.AreEqual("https://appharbor.com/applications/:application/collaborators/5", createResult.Location); } @@ -71,7 +71,7 @@ public void Try_Create_Existing_Collaborator() { var createResult = ExistingDataDataApi.CreateCollaborator(ApplicationId, "some@mail.com", Model.CollaboratorType.Collaborator); Assert.IsNotNull(createResult); - Assert.AreEqual(AppHarbor.Model.CreateStatus.AlreadyExists, createResult.CreateStatus); + Assert.AreEqual(AppHarbor.Model.CreateStatus.AlreadyExists, createResult.Status); Assert.AreEqual(0, createResult.ID); Assert.AreEqual(null, createResult.Location); } @@ -81,7 +81,7 @@ public void Create_Non_Existing_ConfigurationVariable() { var createResult = Api.CreateConfigurationVariable(ApplicationId, "somekey", "somevalue"); Assert.IsNotNull(createResult); - Assert.AreEqual(AppHarbor.Model.CreateStatus.Created, createResult.CreateStatus); + Assert.AreEqual(AppHarbor.Model.CreateStatus.Created, createResult.Status); Assert.AreEqual(5, createResult.ID); Assert.AreEqual("https://appharbor.com/applications/:application/configurationvariables/5", createResult.Location); } @@ -91,7 +91,7 @@ public void Try_Create_Existing_ConfigurationVariable() { var createResult = ExistingDataDataApi.CreateConfigurationVariable(ApplicationId, "somekey", "somevalue"); Assert.IsNotNull(createResult); - Assert.AreEqual(AppHarbor.Model.CreateStatus.AlreadyExists, createResult.CreateStatus); + Assert.AreEqual(AppHarbor.Model.CreateStatus.AlreadyExists, createResult.Status); Assert.AreEqual(0, createResult.ID); Assert.AreEqual(null, createResult.Location); } @@ -101,7 +101,7 @@ public void Create_Non_Existing_Hostname() { var createResult = Api.CreateHostname(ApplicationId, "somehostname.com"); Assert.IsNotNull(createResult); - Assert.AreEqual(AppHarbor.Model.CreateStatus.Created, createResult.CreateStatus); + Assert.AreEqual(AppHarbor.Model.CreateStatus.Created, createResult.Status); Assert.AreEqual(5, createResult.ID); Assert.AreEqual("https://appharbor.com/applications/:application/hostnames/5", createResult.Location); } @@ -111,7 +111,7 @@ public void Try_Create_Existing_Hostname() { var createResult = ExistingDataDataApi.CreateHostname(ApplicationId, "somehostname.com"); Assert.IsNotNull(createResult); - Assert.AreEqual(AppHarbor.Model.CreateStatus.AlreadyExists, createResult.CreateStatus); + Assert.AreEqual(AppHarbor.Model.CreateStatus.AlreadyExists, createResult.Status); Assert.AreEqual(0, createResult.ID); Assert.AreEqual(null, createResult.Location); } @@ -121,7 +121,7 @@ public void Create_Non_Existing_ServiceHook() { var createResult = Api.CreateServicehook(ApplicationId, "http://someurl.com"); Assert.IsNotNull(createResult); - Assert.AreEqual(AppHarbor.Model.CreateStatus.Created, createResult.CreateStatus); + Assert.AreEqual(AppHarbor.Model.CreateStatus.Created, createResult.Status); Assert.AreEqual(5, createResult.ID); Assert.AreEqual("https://appharbor.com/applications/:application/servicehooks/5", createResult.Location); } @@ -131,7 +131,7 @@ public void Try_Create_Existing_ServiceHook() { var createResult = ExistingDataDataApi.CreateServicehook(ApplicationId, "http://someurl.com"); Assert.IsNotNull(createResult); - Assert.AreEqual(AppHarbor.Model.CreateStatus.AlreadyExists, createResult.CreateStatus); + Assert.AreEqual(AppHarbor.Model.CreateStatus.AlreadyExists, createResult.Status); Assert.AreEqual(0, createResult.ID); Assert.AreEqual(null, createResult.Location); } @@ -139,14 +139,20 @@ public void Try_Create_Existing_ServiceHook() [TestMethod] public void Edit_Existing_Application() { - var edited = Api.EditApplication(ApplicationId, new Model.Application()); + var edited = Api.EditApplication(ApplicationId, new Model.Application() + { + Name = "SomeName" + }); Assert.IsTrue(edited); } [TestMethod] public void Edit_Non_Existing_Application() { - var edited = Api.EditApplication(":notexistsapplication", new Model.Application()); + var edited = Api.EditApplication(":notexistsapplication", new Model.Application() + { + Name = "SomeName" + }); Assert.IsFalse(edited); } @@ -155,7 +161,8 @@ public void Edit_Existing_Collaborator() { var edited = Api.EditCollaborator(ApplicationId, new Model.Collaborator() { - ID = 5 + ID = 5, + Role = Model.CollaboratorType.Collaborator, }); Assert.IsTrue(edited); } @@ -165,7 +172,8 @@ public void Edit_Non_Existing_Collaborator() { var edited = Api.EditCollaborator(ApplicationId, new Model.Collaborator() { - ID = 6 + ID = 6, + Role = Model.CollaboratorType.Collaborator, }); Assert.IsFalse(edited); } @@ -175,17 +183,21 @@ public void Edit_Existing_ConfigurationVariable() { var edited = Api.EditConfigurationVariable(ApplicationId, new Model.ConfigurationVariable() { - ID = 5 + ID = 5, + Key = "somekey", + Value = "somevalue", }); Assert.IsTrue(edited); } [TestMethod] - public void Edit_Non_Existing_Hostname() + public void Edit_Non_Existing_ConfigurationVariable() { var edited = Api.EditConfigurationVariable(ApplicationId, new Model.ConfigurationVariable() { - ID = 6 + ID = 6, + Key = "somekey", + Value = "somevalue", }); Assert.IsFalse(edited); }