Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Many changes... #20

Closed
wants to merge 21 commits into from

3 participants

@ducngtuan

Sorry, at first I just want to fix some bugs but then I think the design is somehow not very nice. And it turns out that I have done some drastic changes. You don't have to pull all my commits, I just hope you could take a look. Here are what I've done:

  1. AuthorizationError should be StandardError or you have to change the raise statements (Net::IMAP::NoResponseError has special constructor which includes a Net::IMAP::Response).
  2. Client is now a class. And I made a Connection class to replace the old Client::* things.
  3. No more Labels class. I made a MailboxController, which controls mailboxes (labels are mailboxes).
  4. Mailbox has some new functions.
  5. The system standard mailboxes can be mapped now. It should be able to map even in non-english Gmail. I've just added support for english and german (which i currently use) till now.

It would be difficult to merge all my commits. I have very little experiences in SE so I messed up :">

ducngtuan added some commits
@ducngtuan ducngtuan Fix AuthorizationError#new, fix Labels#all bug for non-english accounts f294ad5
@ducngtuan ducngtuan Prepare new spec tests for refactoring. 74b6531
@ducngtuan ducngtuan Refactor module Gmail, no more compatible! 4584f4d
@ducngtuan ducngtuan Refactor Gmail::Client. TODO: create PlainAuthenticator and XOAuthent…
…icator to replace the old Plain and XOAuth classes.
b76bd1b
@ducngtuan ducngtuan Refactor Gmail::Client, add Gmail::Connection classes. 99f96da
@ducngtuan ducngtuan Add Gmail::Labels d6dac71
@ducngtuan ducngtuan Implement Gmail::Labels#mailbox 748f969
@ducngtuan ducngtuan Rename Gmail::Labels to Gmail::MailController. 286b7e8
@ducngtuan ducngtuan Implement Gmail::Mailbox, Gmail::MailboxController#switch_to_mailbox. 84f2482
@ducngtuan ducngtuan Prepare for refator Gmail::MailboxController and Gmail::Mailbox. b921696
@ducngtuan ducngtuan Change Gmail::MailController, need performance improvement. cfcb38d
@ducngtuan ducngtuan Done refactor Gmail::MailController. e61c32a
@ducngtuan ducngtuan Done with Gmail::Mailbox, waiting for optimizing! ffe0176
@ducngtuan ducngtuan Simplify Gmail::Mailbox 2abbcb0
@ducngtuan ducngtuan Fix Gmail::Mailbox#initzialize to not call Gmail::MailboxController#c…
…reate.
d814d15
@ducngtuan ducngtuan Implement simple i18n for system mailboxes like inbox, all mail, star…
…red...
af16fea
@ducngtuan ducngtuan Done with Gmail::Message and message compose function of Gmail::Clien…
…t. About to test API compatibility with original version from nu7hatch.
58fc5b0
@ducngtuan ducngtuan Add missing file message_composer.rb. Change README, version is now 0…
….4.1.
1ce8261
@ducngtuan ducngtuan Fix small error in client.rb, clients log in by default. fe02fce
@ducngtuan ducngtuan Repair small places in codes. Message#star! and unstar! work now. Cod…
…es need to be cleaned.
9f4a8ae
@nu7hatch
Owner

Thanks for your commitment, but I just can't apply your changes because it's too much with too big mess. Sorry, maybe your'e right that current version isn't ideal in architectural meaning, but it's quite well tested and just works fine. This is the most important thing right now...

@ducngtuan

It's ok. I think i would play around with it myself a little more. Hope that we would work together on this later.
Thanks for your reply.

@bootstraponline bootstraponline referenced this pull request in gmailgem/gmail
Closed

Many changes... #20

@bootstraponline

This issue was moved to gmailgem/gmail#20

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 16, 2011
  1. @ducngtuan
Commits on Feb 17, 2011
  1. @ducngtuan
  2. @ducngtuan
  3. @ducngtuan

    Refactor Gmail::Client. TODO: create PlainAuthenticator and XOAuthent…

    ducngtuan authored
    …icator to replace the old Plain and XOAuth classes.
  4. @ducngtuan
  5. @ducngtuan

    Add Gmail::Labels

    ducngtuan authored
  6. @ducngtuan
  7. @ducngtuan
  8. @ducngtuan
Commits on Feb 18, 2011
  1. @ducngtuan
Commits on Feb 19, 2011
  1. @ducngtuan
  2. @ducngtuan
  3. @ducngtuan
  4. @ducngtuan

    Simplify Gmail::Mailbox

    ducngtuan authored
  5. @ducngtuan
  6. @ducngtuan
  7. @ducngtuan

    Done with Gmail::Message and message compose function of Gmail::Clien…

    ducngtuan authored
    …t. About to test API compatibility with original version from nu7hatch.
  8. @ducngtuan
Commits on Feb 20, 2011
  1. @ducngtuan
  2. @ducngtuan
Commits on Feb 21, 2011
  1. @ducngtuan
Something went wrong with that request. Please try again.