Update shareddata.h #108
Merged
Update shareddata.h #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qix-
reviewed
Apr 30, 2021
There was a problem hiding this comment.
I've submitted some rewording to be a bit more clear and concise - I'm not a maintainer and this isn't a "do this or it's wrong" type of deal, just some suggestions. As-is it's perfectly understandable, but I believe the changes make things a bit more clear. Take it or leave it, doesn't matter :)
Co-authored-by: Qix <Qix-@users.noreply.github.com>
Co-authored-by: Qix <Qix-@users.noreply.github.com>
Co-authored-by: Qix <Qix-@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 90.20% 90.20%
=======================================
Files 24 24
Lines 1613 1613
=======================================
Hits 1455 1455
Misses 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.