Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build commands support for multi-line commands #1194

Merged
merged 10 commits into from Apr 18, 2019
Merged

Build commands support for multi-line commands #1194

merged 10 commits into from Apr 18, 2019

Conversation

sahare92
Copy link
Contributor

Input:
Screen Shot 2019-04-15 at 15 02 10

Result:
Screen Shot 2019-04-15 at 15 01 55

liranbg
liranbg requested changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@liranbg liranbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, few changes to make the iteration more readable would be nicer

pkg/processor/build/builder.go Show resolved Hide resolved
pkg/processor/build/builder.go Show resolved Hide resolved
pkg/processor/build/builder.go Show resolved Hide resolved
pkg/processor/build/builder.go Show resolved Hide resolved
pkg/processor/build/builder.go Show resolved Hide resolved
pkg/processor/build/builder.go Outdated Show resolved Hide resolved
pkg/processor/build/builder.go Show resolved Hide resolved
@pavius pavius merged commit 129aa9c into nuclio:development Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranbg liranbg liranbg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sahare92 @liranbg @pavius