Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming container as namespace + function #633

Merged
merged 4 commits into from Mar 10, 2018
Merged

Naming container as namespace + function #633

merged 4 commits into from Mar 10, 2018

Conversation

sony2
Copy link
Contributor

@sony2 sony2 commented Mar 9, 2018

Using the function name as container name in docker.

@pavius
Copy link
Contributor

pavius commented Mar 9, 2018

Good idea :) However, to be correct the name would have to include the namespace as well (e.g. fmt.Sprintf("%s-%s", deployOptions.FunctionConfig.Meta.Namespace, deployOptions.FunctionConfig.Meta.Name)

Even though the local platform is for testing / dev, it should impose as little limitations as possible (in this case, would've broken the ability to create the same function in two different namespaces).

@sony2 sony2 changed the title Naming container as function Naming container as namespace + function Mar 9, 2018
@pavius pavius merged commit edd65cb into nuclio:development Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants