Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking Pool Docs #2597

Merged
merged 8 commits into from Apr 9, 2021
Merged

Staking Pool Docs #2597

merged 8 commits into from Apr 9, 2021

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented Mar 16, 2021

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Based over #2596. Document base Staking contract and PoolingStakingContractV2.

Issues fixed/closed:

  • Fixes #...

Related to #2596 .
Closes #2202

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

@derekpierre derekpierre added documentation Effects the official documentation Staking labels Mar 16, 2021
derekpierre added a commit to derekpierre/nucypher that referenced this pull request Mar 17, 2021
derekpierre added a commit to derekpierre/nucypher that referenced this pull request Mar 17, 2021
@derekpierre derekpierre force-pushed the staking-pool-docs branch 2 times, most recently from 1f8b8f6 to b460058 Compare March 17, 2021 17:55
derekpierre added a commit to derekpierre/nucypher that referenced this pull request Mar 22, 2021
@derekpierre derekpierre marked this pull request as ready for review March 22, 2021 15:28
@derekpierre derekpierre changed the title [WIP] Staking Pool Docs Staking Pool Docs Mar 22, 2021
Copy link
Member

@cygnusv cygnusv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

derekpierre added a commit to derekpierre/nucypher that referenced this pull request Mar 25, 2021
Co-Authored-By: cygnusv <david@nucypher.com>
derekpierre added a commit to derekpierre/nucypher that referenced this pull request Mar 26, 2021
derekpierre added a commit to derekpierre/nucypher that referenced this pull request Mar 26, 2021
derekpierre added a commit to derekpierre/nucypher that referenced this pull request Mar 26, 2021
Co-Authored-By: cygnusv <david@nucypher.com>
derekpierre added a commit to derekpierre/nucypher that referenced this pull request Mar 26, 2021
@KPrasch KPrasch changed the base branch from main to docs April 5, 2021 19:56
@KPrasch KPrasch changed the base branch from docs to main April 5, 2021 19:56
@KPrasch
Copy link
Member

KPrasch commented Apr 5, 2021

Looks like this PR needs a rebase. Ah, nevermind, it's just dependant on open PR #2596

@KPrasch KPrasch merged commit a93af0d into nucypher:main Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Effects the official documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs for staking contracts or readme for pooling contract
5 participants