Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule2 typos clarification #47

Open
wants to merge 8 commits into
base: master
from

Conversation

@psychemedia
Copy link
Collaborator

psychemedia commented Dec 11, 2019

No description provided.

ten-simple-rules-dockerfiles.Rmd Outdated Show resolved Hide resolved
Automated builds can be complex to set up, and details are out of scope of this article.
The documentation and tools of container registries, e.g., [Docker Hub](https://docs.docker.com/docker-hub/builds/) or [GitLab](https://docs.gitlab.com/ee/user/packages/container_registry/index.html#build-and-push-images) instances, but also of CI platforms, e.g. [GitHub actions](https://github.com/actions/starter-workflows/tree/master/ci), a GitHub actions for `repo2docker` [@husain_repo2docker-action_2019; @scottyhq_repo2docker-githubci_2019], or [CircleCI](https://circleci.com/orbs/registry/orb/circleci/docker#commands-build), can help you get started.
The documentation for, and toolsets provided by container registries such as [Docker Hub](https://docs.docker.com/docker-hub/builds/) or [GitLab](https://docs.gitlab.com/ee/user/packages/container_registry/index.html#build-and-push-images) as well as CI platforms such as [GitHub actions](https://github.com/actions/starter-workflows/tree/master/ci) or [CircleCI](https://circleci.com/orbs/registry/orb/circleci/docker#commands-build) can help you get started; tools may also be available to automate builds using intermediate tools, such as the `repo2docker` Github action [@husain_repo2docker-action_2019; @scottyhq_repo2docker-githubci_2019],
You should avoid publishing an image in a public registry with `docker push`, because it is opaquely breaking the linkage between `Dockerfile` and image.

This comment has been minimized.

Copy link
@vsoch

vsoch Dec 11, 2019

Collaborator

I think we need to do a check on this GitHub action - many (previously working actions) don't work after the API changes. If it still works, likely it needs to be called a GitHub workflow.

This comment has been minimized.

Copy link
@vsoch

vsoch Dec 11, 2019

Collaborator

okay if this is the linked repo - https://github.com/scottyhq/repo2docker-githubci it looks like it's been updated recently and should be good. Should we reference it as a GitHub workflow instead of action?

ten-simple-rules-dockerfiles.Rmd Outdated Show resolved Hide resolved
ten-simple-rules-dockerfiles.Rmd Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.