Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet.PackageManagement: If package restore fails, satellite files for the successfully restored packages are not restored #28

Closed
deepakaravindr opened this issue Feb 4, 2015 · 1 comment
Assignees
Labels
Priority:2 Issues for the current backlog. Product:VS.Client Type:Bug
Milestone

Comments

@deepakaravindr
Copy link

NuGet.PackageManagement: If restoring a package fails, satellite files for the successfully restored packages are not restored

Repro steps:

  1. Create a console Application
  2. Install-Package Microsoft.AspNet.Razor.fr
  3. Install one or more packages from a private feed such that it is not available from NuGet official
  4. Now, disable the private feed and only retain the official feed
  5. Delete packages folder
  6. Initiate restore packages through build or using 'Restore' button on the UI window
  7. Package restore will fail for all the packages from the private feed

Expected:

Satellite files for the Microsoft.AspNet.Razor.Fr is copied successfully

Actual:

Satellite files are not copied for Microsoft.AspNet.Razor.Fr and it never becomes available for restore again

@deepakaravindr deepakaravindr self-assigned this Feb 4, 2015
@deepakaravindr deepakaravindr added the Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. label Feb 4, 2015
@deepakaravindr deepakaravindr modified the milestone: 3.0.0-beta Feb 10, 2015
@deepakaravindr deepakaravindr modified the milestones: 3.0.0-rc, 3.0.0-beta Feb 20, 2015
@deepakaravindr deepakaravindr changed the title NuGet.PackageManagement: If restoring a package fails, satellite files for the successfully restored packages are not restored NuGet.PackageManagement: If package restore fails, satellite files for the successfully restored packages are not restored Mar 13, 2015
@deepakaravindr deepakaravindr modified the milestones: 3.0.0-rc, 3.0.0-rc2 Mar 13, 2015
@deepakaravindr deepakaravindr added Priority:2 Issues for the current backlog. 1 - Ready and removed Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. labels Apr 1, 2015
@ChrisSfanos ChrisSfanos modified the milestones: 3.0.0-rc2, 3.0.0-RTM Apr 9, 2015
@deepakaravindr
Copy link
Author

It does not repro

This has not been true for a long time now, since, RestorePackages reports errors through PackageRestoreFailedEvent and does not throw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:2 Issues for the current backlog. Product:VS.Client Type:Bug
Projects
None yet
Development

No branches or pull requests

2 participants