Nuke.Common 10.0.0 generates emtpy projects in [Solution(GenerateProjects = true)]

[ImoutoChan]

Usage Information

Nuke.Common 10.0.0

Description

a535265#diff-478e591e410ed83250cb53d63a15cf82ace1a1fc90e0b8a5da6bcb424c00760eR115

public IReadOnlyCollection<SolutionFolder> SolutionFolders => Solution.AllSolutionFolders.Where(x => x.Parent == this).ToList();

So I think this is the problem, because generated SolutionItem (folders in my case) is different from original folders, operator == returns false for every nested project

Reproduction Steps

• Have slnx (maybe sln too?) with nested folders and projects in them
• Use [Solution(GenerateProjects = true)]
• Use generated folders in generated solution

Expected Behavior

The folders are generated and not empty

Actual Behavior

The folders are generated but contains zero projects

Regression?

Yes

Known Workarounds

No response

Could you help with a pull-request?

No

[IT-VBFK]

Have slnx (maybe sln too?) with nested folders and projects in them

It's the same for "old" sln format

[jnyrup]

Here's a self-contained solution using .sln to reproduce.
ConsoleApp43.zip

With net9 + nuke 9.0.4 Solution.NestedFolder.ConsoleApp43 is not null.
With net10 + nuke 10.0.0 Solution.NestedFolder.ConsoleApp43 is null.

[lahma]

Maybe a pull request to fix things would be better.

[IT-VBFK]

With net9 + nuke 9.0.4 Solution.NestedFolder.ConsoleApp43 is not null.
With net10 + nuke 10.0.0 Solution.NestedFolder.ConsoleApp43 is null.

In addition: net10.0 + nuke 9.0.4 it also works

[jnyrup]

It seems with the new modelling that SolutionFolder.Projects (and perhaps also SolutionFolder.SolutionFolders as well) can no longer just do Where(x => x.Parent == this) as SolutionFolders are created multiple times.
The wrapped SolutionFolderModel is what's only created once in Solution.wrappers.

I'm not sure if it fits into the design, but if I change the two SolutionFolder properties to compare the object's SolutionFolderModel, it seems to work.

public IReadOnlyCollection<Project> Projects => Solution.AllProjects.Where(x => x.Parent is SolutionFolder sf && sf.GetModel() == GetModel()).ToList();
public IReadOnlyCollection<SolutionFolder> SolutionFolders => Solution.AllSolutionFolders.Where(x => x.Parent is SolutionFolder sf && sf.GetModel() == GetModel()).ToList();

[IT-VBFK]

Can confirm this would fix this, also for nested solution folders.

[IT-VBFK]

I'm not sure if it fits into the design, but if I change the two SolutionFolder properties to compare the object's SolutionFolderModel, it seems to work.

You could try if this gets through :)

Edit: Opened a PR but give the credit to @jnyrup

[DemoBytom]

This still doesn't work in 10.0.1 as the #1575 was closed without being merged.

    Directory: C:\Git\DemoEngine\test


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d-----         1.12.2025     23:10                Demo.Engine.Core.UTs
d-----         1.12.2025     23:10                Demo.Engine.UTs
d-----         1.12.2025     23:10                Demo.Tools.Common.UTs
d-----         1.12.2025     23:10                Demo.Tools.SourceGenerators.UTs

NUKE Execution Engine version 10.0.1 (Windows,.NETCoreApp,Version=v10.0)
​
╬════════════════
║ VerifyTests
╬═══════
​
23:32:07 [INF] Source generated count 0 vs actual count 4
23:32:07 [INF] Source generated project null vs actual project C:\Git\DemoEngine\test\Demo.Engine.UTs\Demo.Engine.UTs.csproj

public Target VerifyTests => t => t
    .Executes(() =>
    {
        Debugger.Launch();
        var testProjectsCnt = Solution.test.Projects.Count;
        var testProjects2Cnt = Solution.AllProjects.Where(p => p.RelativePath.StartsWithOrdinalIgnoreCase("test")).Count();

        Log.Information("Source generated count {sourceGeneratedCnt} vs actual count {actualCnt}", testProjectsCnt, testProjects2Cnt);

        var sgTestProject = Solution.test.Demo_Engine_UTs;
        var testProject = Solution.AllProjects.Where(p => p.Name == "Demo.Engine.UTs").FirstOrDefault();

        Log.Information("Source generated project {sgTestProject} vs actual project {actualProject}", sgTestProject ?? "null", testProject ?? "null");
    });

[jnyrup]

@DemoBytom This had a better fix in fccf33b by Matthias instead of my hack

The reason seems to be that this and other commits weren't merged from develop and into master before releasing 10.0.1

[DemoBytom]

@jnyrup oh I see, great! :) I didn't realize there was a better fix in place, and I see 10.1.0 is now merged into master, so it should be ok now :)