Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced hardcoded strings for proper i18n resources #455

Closed
wants to merge 904 commits into from
Closed

Replaced hardcoded strings for proper i18n resources #455

wants to merge 904 commits into from

Conversation

emlautarom1
Copy link
Contributor

I removed some of the hardcoded texts, specially in the "track popup", for i18 resources and also I added a Spanish version for those strings.

Also, concerning code style, some components use useTranslation and others use withTranslation decorator. I'm not a react dev, but couldn't we standarize a way to handle internationalization?

Charles Jacquin and others added 30 commits March 31, 2019 19:50
feat(equalizer): add some winamp presets
458a505
feat(equalizer): add preamp support
5375421
feat(equalizer): add audio visualization support
3faa8ee
fix(equalizer): good cursor item when user interact with chart
4bff6b9
fix(equalizer): resize canvas and set min width
3b2a6f3
@nukeop
Merge pull request #296 from charjac/feat.equalizer
16c0336 
feat equalizer
@nukeop
Hide some elements of the sidebar in compact style
1620687
@nukeop
Avoid class name collision with equalizer styling
7bd57df
@nukeop
Downloads view boilerplate
b6faa16
@nukeop
Fix thumbnails on track rows
520eae6
@nukeop
Refactor: turn track row popups into their own containers that manage
724cf35 
their own props
@nukeop
Raise toast container above all semantic ui components
7cbf0d5
@nukeop
Set max size for notification icons
71887d9
@nukeop
Style changes for settings
be91e67
@nukeop
Merge pull request #308 from nukeop/feature/better-settings
49bbe03 
Style changes for settings
@nukeop
Replace existing popups to simplify code
685d539
@nukeop
Remove unused props from track rows everywhere
e997676
@nukeop
Boilerplate for downloads, ipc action, display components and server
8784d8e 
side downloading
@nukeop
Download queue display + empty state
27a25b6
@nukeop
Use ipc to get download data
be578f3
@nukeop
Handle downloads via ipc, report on progress
d7f0277
@nukeop
Save files with correct extension
ca011bd
@nukeop
Styles for download list and its items
1ba4366
@nukeop
Import downloads features in all server versions
d195533
@nukeop
Merge pull request #309 from nukeop/feature/downloads
c63ce78 
Feature/downloads
@nukeop
Improve slider display in settings
8b9dc53
@nukeop
Allow clearing finished items from downloads
c29b800
@nukeop
help button stub
fc42799
@nukeop
Simple 'about' window
cdcbfdb
@nukeop
Minor style improvements
e63723b
karevn and others added 16 commits August 12, 2019 21:30
@karevn @nukeop
Repeat search on Enter keypress in the search box (#444)
9d79668 
* Repeat search on Enter keypress in the search box

* 13 => constant
@karevn @nukeop
Don't show empty search result categories (#443)
0f1732f
@karevn @nukeop
Got rid of Happypack (#449)
4e8bdaa 
The build process without Happypack is consistently faster by 10-15%, so this tool does no good for this project.
@jenyeeiam @nukeop
Tests player queue (#451)
1ff7aa0 
* onclick of queue menu more items tests

* added icon tests and cleaning up

* moved mount inside the it function

* refactor and better test names
@nukeop
Update and rename nodejs.yml to build-linux.yml
9c01d98
@nukeop
Create temp
86bad77
@nukeop
Rename build-linux.yml to .github/workflows/build-linux.yml
99381af
@nukeop
Delete temp
d1a97fe
@nukeop
Add support for more file formats. Fixes #450
de19ade
@nukeop
Fix config initialization issue; closes #453
d479ecb
@nukeop
Fix bugs introduced by recent last.fm related changes
526eb80
@emlautarom1 @nukeop
Improved and extended Spanish translation (#454)
1d91ae4 
* Fixed and improved Spanish translation

* Fixed typos

* Typos...
@nukeop
Update README.md
d59695c
@emlautarom1
Merge pull request #1 from nukeop/master
67f9bdb 
Sync with original repository
@emlautarom1
Replaced hardcoded text for proper i18 sources
2a68f8c
@emlautarom1
Removed more hardcoded text
c3368fb
@emlautarom1 emlautarom1 changed the title Replaced hardcoded texts for proper i18 resources Replaced hardcoded strings for proper i18n resources Aug 18, 2019
@nukeop
Copy link
Owner

nukeop commented Aug 21, 2019

The json is malformed, could you fix that?

@emlautarom1
Copy link
Contributor Author

It should be ok now.

@nukeop nukeop closed this Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet