Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced hardcoded strings for proper i18n resources #455

Closed

Conversation

@emlautarom1
Copy link
Contributor

commented Aug 18, 2019

I removed some of the hardcoded texts, specially in the "track popup", for i18 resources and also I added a Spanish version for those strings.

Also, concerning code style, some components use useTranslation and others use withTranslation decorator. I'm not a react dev, but couldn't we standarize a way to handle internationalization?

charjac and others added 30 commits Mar 28, 2019
feat equalizer
Style changes for settings
Feature/downloads
karevn and others added 16 commits Aug 12, 2019
* Repeat search on Enter keypress in the search box

* 13 => constant
The build process without Happypack is consistently faster by 10-15%, so this tool does no good for this project.
* onclick of queue menu more items tests

* added icon tests and cleaning up

* moved mount inside the it function

* refactor and better test names
* Fixed and improved Spanish translation

* Fixed typos

* Typos...
Sync with original repository
@emlautarom1 emlautarom1 changed the title Replaced hardcoded texts for proper i18 resources Replaced hardcoded strings for proper i18n resources Aug 18, 2019
nukeop and others added 6 commits Aug 18, 2019
@nukeop

This comment has been minimized.

Copy link
Owner

commented Aug 21, 2019

The json is malformed, could you fix that?

@emlautarom1

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

It should be ok now.

@nukeop nukeop force-pushed the nukeop:master branch from 13f1d88 to 81de3d1 Sep 30, 2019
@nukeop nukeop closed this Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.