Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customisable localisation of Feedback #3

Merged
merged 8 commits into from
Jan 27, 2016
Merged

Conversation

mazine
Copy link
Contributor

@mazine mazine commented Jan 25, 2016

  1. Introduced Feedback.Message to store a message ID.
  2. Added message field to an instance of Feedback, to localise messages on demand.
  3. Covered all feedback cases with tests.
  4. Moved message IDs to constants to simplify testing.
  5. Not sure about new setters of Feedback class. I've updated them just to keep the API. But are the setter really required for this class? I can hardly imagine the use-case. Without them there is no need in the Feedback.Message class.

mazine referenced this pull request in mazine/zxcvbn4j Jan 26, 2016
@vvatanabe
Copy link
Member

5. Not sure about new setters of Feedback class.
I've updated them just to keep the API.
But are the setter really required for this class?
I can hardly imagine the use-case.
Without them there is no need in the Feedback.Message class.

That's right. Setters of Feedback class does not need. So it is and I delete it.
And, thank you for me to fix the bug of "match.token".
Test is now very beautiful.
We're going to merge this PR.

vvatanabe added a commit that referenced this pull request Jan 27, 2016
It was merged. Thank you for me a great PR !
Immediately, we will upload to the Maven repository. Please wait a moment.
@vvatanabe vvatanabe merged commit a518370 into nulab:master Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants