Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skins: Do not save extra file attributes in .zip #149

Merged
merged 1 commit into from May 30, 2019

Conversation

Projects
None yet
2 participants
@bmwiedemann
Copy link
Contributor

commented May 9, 2019

Do not save extra file attributes in .zip (e.g. ctime, atime)
to make it easier to make a reproducible build
See https://reproducible-builds.org/ for why this is good.

Note: Build results became fully deterministic with
this zip patch

This PR was done while working on reproducible builds for openSUSE.

skins: Do not save extra file attributes in .zip
to make it easier to make a reproducible build
See https://reproducible-builds.org/ for why this is good.

@noscript noscript merged commit 434ded6 into nulloy:master May 30, 2019

@noscript

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Sorry for the delay with the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.