Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd ragdoll style overrides #876
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
...I have no idea why my commit shows up as @pongsarunb |
This comment has been minimized.
This comment has been minimized.
you have encountered fungwah bug |
|
LGTM Cowmangler thing will be added some other day |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
robootgit commentedNov 7, 2019
•
edited
This patch adds an option to change the way ragdolls look.
Video demo: https://youtu.be/9Ds83esfbKc
There is also an option to only modify ragdolls that are spawned from players that were killed by the local player. This is enabled by default.
Currently, it will only change the ragdoll style if it is not already set. If a ragdoll is already set to be a gib and you have the override set to a gold ragdoll, it will spawn as a gib. If people want, you could easily add an option to "force" the selected ragdoll style.
I tested this for about half an hour in casual and I found that it will occasionally fail if the person you just killed was airborn. I don't know if this is an issue with the way I detect if the ragdoll belongs to a person the player just killed, or if it's a bug with the game.