Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ragdoll style overrides #876

Merged
merged 4 commits into from Nov 23, 2019
Merged

Add ragdoll style overrides #876

merged 4 commits into from Nov 23, 2019

Conversation

@robootgit
Copy link
Collaborator

robootgit commented Nov 7, 2019

This patch adds an option to change the way ragdolls look.

Video demo: https://youtu.be/9Ds83esfbKc

There is also an option to only modify ragdolls that are spawned from players that were killed by the local player. This is enabled by default.

Currently, it will only change the ragdoll style if it is not already set. If a ragdoll is already set to be a gib and you have the override set to a gold ragdoll, it will spawn as a gib. If people want, you could easily add an option to "force" the selected ragdoll style.

I tested this for about half an hour in casual and I found that it will occasionally fail if the person you just killed was airborn. I don't know if this is an issue with the way I detect if the ragdoll belongs to a person the player just killed, or if it's a bug with the game.

robootgit and others added 2 commits Nov 7, 2019
@robootgit

This comment has been minimized.

Copy link
Collaborator Author

robootgit commented Nov 7, 2019

...I have no idea why my commit shows up as @pongsarunb

@BenCat07

This comment has been minimized.

Copy link
Collaborator

BenCat07 commented Nov 10, 2019

...I have no idea why my commit shows up as @pongsarunb

you have encountered fungwah bug

src/hacks/Ragdolls.cpp Show resolved Hide resolved
src/hacks/Ragdolls.cpp Show resolved Hide resolved
Copy link
Collaborator

BenCat07 left a comment

LGTM

Cowmangler thing will be added some other day

@BenCat07 BenCat07 merged commit be1bc98 into nullworks:master Nov 23, 2019
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.