-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building with CMake on posix systems #677
Conversation
@xhochy thanks, I have added it to the queue for review. |
Finally you started doing something reasonable
…On 1/7/21, Valentin Haenel ***@***.***> wrote:
@xhochy thanks, I have added it to the queue for review.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#677 (comment)
|
@xhochy would you agree that in order to test this, it will be best to buildout |
Yes, we do that explicitly on conda-forge: https://github.com/conda-forge/llvmlite-feedstock/pull/50/files Otherwise with a recipe where you don't have the environment variable overridden |
This PR looks okay. Just need a buildfarm pass. |
I finally managed to schedule this on our Anaconda internal build farm today, but It needed a quick hack under the hood to insert the variable export. It's now running as |
The farm run ran through fine, but I never saw a call to |
Yes, the |
Indeed, I did export that environment variable but still didn't see any calls to |
@xhochy perhaps it makes sense to add a |
Just to double check, this should work on OSX too, right? |
So, this is a bit strange, probably an error on my part. I added the following lines to produce debugging output:
I then ran the following command:
And I see the following in the build log:
Help? |
|
@xhochy ahhhhhh! Great catch! Thank you 🙏 |
So I tried this and the env var is indeed picked up, but I now get:
|
Quick update here: this is currently falling over on all linux hosts on our build farm. I'll need more time to debug this, but it's probably an issue with the farm rather than with the PR. |
It's an issue with the PR, the |
@xhochy thanks for fixing this up, re-running now on the build farm as |
any news to merge?? |
@elawady55 the build has gotten further now, but it failed on the Anaconda internal build farm with:
|
I have now created a job internally called |
quick update here: it is looking good so far, it has built on most platforms and I am only waiting for the RaspberryPis to complete. They are notoriously slow due to their limited compute capacity. |
Another fix is to remove the Edit, forgot link: https://github.com/numba/llvmlite/blob/master/conda-recipes/llvmlite/meta.yaml#L26 |
Anaconda internal farm is green, this is now RTM from my side. |
Also, as a double-check I did look at the logs and searched for the
So, this confirms the build farm didn't just bypass the |
@xhochy thank you for your patience and persistence in getting this over the line. It will be part of the release tomorrow. |
This eases cross-compiling as seen in conda-forge/llvmlite-feedstock#50