Disallow alwaysinline and noinline on functions #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding "alwaysinline" and "noinline" attributes to a function results in an error similar to the following when compiling with LLVM: ``` Attributes 'noinline and alwaysinline' are incompatible! LLVM ERROR: Broken module found, compilation aborted! ``` and then the interpreter is killed. This commit prevents both attributes being added at the Python level, to prevent the above error message and termination.
|
I looked at the build failure, this has nothing to do with the PR but is caused by an upgrade of |
The `llvm:ref` directive seems to be unknown. I'm not sure how it did work, but as this is used precisely once in the docs it seems reasonable to just replace it with a URL.
|
Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding "alwaysinline" and "noinline" attributes to a function results in an error similar to the following when compiling with LLVM:
and then the interpreter is killed. This PR prevents both attributes being added at the Python level, to prevent the above error message and termination.